This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
worker: apply some preparations to Ayo’s internals #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
force-pushed
the
workers-impl-precommit
branch
from
5dced6b
to
8757c27
Compare
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
This makes some of the internal `AsyncWrap::MakeCallback()` utility wrappers throw rather than crash the process when the requested method is not present on the `this` object. Doing so makes it easier for future code to expose C++ objects directly to userland, where JS code can overwrite or delete such methods. PR-URL: ayojs#82
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
Previously, the `Environment` destructor did not release its `fs_stats_field_array` memory. The memory is allocated when the `fs` module is initialized and calls `GetStatValues()`. PR-URL: ayojs#82
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
This adds pairs of methods to the `Environment` class and to public APIs which can add and remove cleanup handlers. Unlike `AtExit`, this API targets addon developers rather than embedders, giving them (and Node’s internals) the ability to register per-`Environment` cleanup work. PR-URL: ayojs#82
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 26, 2017
Qard
approved these changes
Sep 26, 2017
This makes some of the internal `AsyncWrap::MakeCallback()` utility wrappers throw rather than crash the process when the requested method is not present on the `this` object. Doing so makes it easier for future code to expose C++ objects directly to userland, where JS code can overwrite or delete such methods. PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
Previously, the `Environment` destructor did not release its `fs_stats_field_array` memory. The memory is allocated when the `fs` module is initialized and calls `GetStatValues()`. PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
This adds pairs of methods to the `Environment` class and to public APIs which can add and remove cleanup handlers. Unlike `AtExit`, this API targets addon developers rather than embedders, giving them (and Node’s internals) the ability to register per-`Environment` cleanup work. PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: ayojs#82 Reviewed-By: Stephen Belanger <[email protected]>
addaleax
force-pushed
the
workers-impl-precommit
branch
from
8757c27
to
55e7e61
Compare
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > This makes some of the internal `AsyncWrap::MakeCallback()` > utility wrappers throw rather than crash the process when > the requested method is not present on the `this` object. > Doing so makes it easier for future code to expose C++ > objects directly to userland, where JS code can overwrite > or delete such methods. > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > Previously, the `Environment` destructor did not release its > `fs_stats_field_array` memory. The memory is allocated when the > `fs` module is initialized and calls `GetStatValues()`. > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > This adds pairs of methods to the `Environment` class and to public APIs > which can add and remove cleanup handlers. > Unlike `AtExit`, this API targets addon developers rather than > embedders, giving them (and Node’s internals) the ability to register > per-`Environment` cleanup work. > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 1, 2017
Original PR: ayojs/ayo#82 > PR-URL: ayojs/ayo#82 > Reviewed-By: Stephen Belanger <[email protected]>
2 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Aug 21, 2018
This adds pairs of methods to the `Environment` class and to public APIs which can add and remove cleanup handlers. Unlike `AtExit`, this API targets addon developers rather than embedders, giving them (and Node\u2019s internals) the ability to register per-`Environment` cleanup work. We may want to replace `AtExit` with this API at some point. Many thanks for Stephen Belanger for reviewing the original version of this commit in the Ayo.js project. Refs: ayojs/ayo#82 PR-URL: nodejs#19377 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply picks a few commits from #58 for easier review.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes