lib: setup IPC channel before console

Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: nodejs/node#16562 Fixes: nodejs/node#16141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
ayojs · Nov 2, 2017 · 55fa471 · 55fa471
1 parent d1dbd95
commit 55fa471
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -40,12 +40,6 @@
     NativeModule.require('internal/process/next_tick').setup();
     NativeModule.require('internal/process/stdio').setup();
 
-    const browserGlobals = !process._noBrowserGlobals;
-    if (browserGlobals) {
-      setupGlobalTimeouts();
-      setupGlobalConsole();
-    }
-
     const perf = process.binding('performance');
     const {
       NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE,
@@ -77,6 +71,12 @@
 
     _process.setupRawDebug();
 
+    const browserGlobals = !process._noBrowserGlobals;
+    if (browserGlobals) {
+      setupGlobalTimeouts();
+      setupGlobalConsole();
+    }
+
     // Ensure setURLConstructor() is called before the native
     // URL::ToObject() method is used.
     NativeModule.require('internal/url');

diff --git a/test/parallel/test-child-process-stdout-ipc.js b/test/parallel/test-child-process-stdout-ipc.js
@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+
+const spawn = require('child_process').spawn;
+
+if (process.argv[2] === 'child') {
+  process.send('hahah');
+  return;
+}
+
+const proc = spawn(process.execPath, [__filename, 'child'], {
+  stdio: ['inherit', 'ipc', 'inherit']
+});
+
+proc.on('exit', common.mustCall(function(code) {
+  assert.strictEqual(code, 0);
+}));