assert: handle sparse arrays in deepStrictEqual

Detect sparse array ends and add a fail early path for unequal array length. PR-URL: nodejs/node#15027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
ayojs · Aug 30, 2017 · 2a3d73f · 2a3d73f
1 parent c83c108
commit 2a3d73f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/assert.js b/lib/assert.js
@@ -180,7 +180,14 @@ function strictDeepEqual(actual, expected) {
   if (Object.getPrototypeOf(actual) !== Object.getPrototypeOf(expected)) {
     return false;
   }
-  if (isObjectOrArrayTag(actualTag)) {
+  if (actualTag === '[object Array]') {
+    // Check for sparse arrays and general fast path
+    if (actual.length !== expected.length)
+      return false;
+    // Skip testing the part below and continue in the callee function.
+    return;
+  }
+  if (actualTag === '[object Object]') {
     // Skip testing the part below and continue in the callee function.
     return;
   }

diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -466,4 +466,7 @@ assertOnlyDeepEqual(
   assertDeepAndStrictEqual(m3, m4);
 }
 
+assertDeepAndStrictEqual([1, , , 3], [1, , , 3]);
+assertOnlyDeepEqual([1, , , 3], [1, , , 3, , , ]);
+
 /* eslint-enable */