Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling, handle RuleReducer.Con in visibleArgs in CorePrettier #1148

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Nov 18, 2024

Never do is ConCall con && con.conArgs(). Always check for ConCallLike

@ice1000 ice1000 added this to the v0.34 milestone Nov 18, 2024
@ice1000 ice1000 added the bug Something isn't working label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (66cb8a2) to head (2ae36d8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/java/org/aya/cli/utils/CompilerUtil.java 0.00% 5 Missing ⚠️
.../java/org/aya/resolve/module/FileModuleLoader.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1148   +/-   ##
=========================================
  Coverage     79.84%   79.84%           
- Complexity     3397     3398    +1     
=========================================
  Files           312      312           
  Lines         10245    10245           
  Branches       1225     1223    -2     
=========================================
  Hits           8180     8180           
- Misses         1395     1397    +2     
+ Partials        670      668    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 merged commit 5fefb33 into main Nov 18, 2024
4 checks passed
@ice1000 ice1000 deleted the ice1000 branch November 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant