Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues related to arrays and meta lit terms, implement debug-show-shapes #1147

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Nov 18, 2024

As title

@ice1000 ice1000 added bug Something isn't working literal labels Nov 18, 2024
@ice1000 ice1000 added this to the v0.34 milestone Nov 18, 2024
@ice1000 ice1000 linked an issue Nov 18, 2024 that may be closed by this pull request
@ice1000 ice1000 changed the title Fix two issues related to arrays and meta lit terms Fix two issues related to arrays and meta lit terms, implement debug-show-shapes Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (4b35a0d) to head (66cb8a2).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
base/src/main/java/org/aya/tyck/ExprTycker.java 72.72% 0 Missing and 3 partials ⚠️
...se/src/main/java/org/aya/normalize/Normalizer.java 50.00% 1 Missing ⚠️
...ain/java/org/aya/cli/interactive/ReplCompiler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1147      +/-   ##
============================================
- Coverage     79.86%   79.84%   -0.03%     
- Complexity     3393     3397       +4     
============================================
  Files           312      312              
  Lines         10232    10245      +13     
  Branches       1220     1225       +5     
============================================
+ Hits           8172     8180       +8     
- Misses         1392     1395       +3     
- Partials        668      670       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000
Copy link
Member Author

ice1000 commented Nov 18, 2024

-0.03 is good enough

@ice1000 ice1000 merged commit 038fdba into main Nov 18, 2024
4 of 6 checks passed
@ice1000 ice1000 deleted the ice1000 branch November 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working literal
Projects
None yet
1 participant