Rescue coerce errors and return an error hash #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatolond
force-pushed
the
bugfix/invalid_date
branch
from
87102e8 to
000810b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using DateTime params (though possibly for other types too) the coerce step can fail because the date is invalid (it can be because it's a day that doesn't exist, such as 29/2 on non-leap years, or a string that cannot be parsed by DateTime).
The current behavior is to let this error bubble up and allow sinatra to return a 500. However, it should be caught by sinatra-browse and return a 400 for a graceful error.
This changes the behavior to catch exceptions around the coerce and return an error. I'm using a generic exception catch, but it could be more specialized to catch an
ArgumentError, which is thrown by DateTime.parse.