-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fpm cookery with rpm spec files #406
Conversation
… from the description
…earn how to write specs so I could do the subpackage way more easily.
…e the spec files instead.
…ferent from the standard at rpm.org but it seems like the way centos' base packages are doing it
…e by the rpm build script
…everal bugs in the rpmbuild script
✅ 46a7ba5 success - wakame-ci/rpmbuild-vnet |
❌ 46a7ba5 failure - wakame-ci/openvnet.integration |
✅ 46a7ba5 success - wakame-ci/rspec |
✅ 46a7ba5 success - wakame-ci/rpmbuild-vnet |
✅ 46a7ba5 success - wakame-ci/openvnet.integration |
The integration test failed once because I was running it manually with the wrong environment variables. Starting the CI again from the beginning and letting each job run their downstream automatically fixed it. |
|
||
Name: openvnet | ||
Version: 0.7%{?dev_release_suffix:dev} | ||
Release: %{release}.el6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use %{dist}
macro for rpmspec.
Release: %{release}%{?dist}
✅ ad92893 success - wakame-ci/rspec |
✅ ad92893 success - wakame-ci/rpmbuild-vnet |
✅ ad92893 success - wakame-ci/openvnet.integration |
❌ ad92893 failure - wakame-ci/openvnet.integration |
❌ ad92893 failure - wakame-ci/openvnet.integration |
✅ ad92893 success - wakame-ci/openvnet.integration |
👍 |
✅ ad92893 success - wakame-ci/openvnet.integration |
✅ ad92893 success - wakame-ci/openvnet.integration |
✅ ad92893 success - wakame-ci/openvnet.integration |
The integration test failure at Aug 22, 2015 3:28:45 AM JST was a router p2v race condition that I've seen happening on develop in nightly builds. The one at Aug 22, 2015 3:47:13 AM JST was a vnet edge failure that I haven't been able to reproduce. While these failures do worry me, I will merge since I haven't been able to reproduce them and we had 4 successful integration tests since then. I highly suspect the failures to not be related to the rpm packages in this PR. |
…iles Replace fpm cookery with rpm spec files
We plan to move away from fpm cookery and back to standard rpm spec files. Rpm spec files are much better documented, more well known in the industry and will allow us more control over the packages.
This PR replaces the OpenVNet packages. The third party packages will be done at a later time.