-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix evm config init #1484
fix: fix evm config init #1484
Conversation
371579d
to
17c7a66
Compare
This commit (17c7a66) has been successfully verified locally. @driftluo @KaoImin
|
Has nothing to do with the current PR. I have already point that in #1457 but be ingored: Why the error message is related to |
https://github.com/axonweb3/axon/blob/main/core/api/src/jsonrpc/error.rs#L57 |
axon/core/api/src/jsonrpc/error.rs Lines 57 to 58 in a2d8e04
The error display should be changed as following: #[display(fmt = "EVM error {}", "decode_revert_msg(&_0.ret)")]
EVM(TxResp), |
17c7a66
to
3e0fffb
Compare
3e0fffb
to
5ba15fe
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
5ba15fe
to
fe64e40
Compare
This comment was marked as abuse.
This comment was marked as abuse.
CI tests run on commit:
CI test list:
Please check ci test results later. |
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
The error message returned by commit (fe64e40) is as follows:
|
if latest_hardfork_info & &enable_contract_limit_flag == enable_contract_limit_flag { | ||
let handle = MetadataHandle::new(CURRENT_METADATA_ROOT.with(|r| *r.borrow())); | ||
let config = handle.get_consensus_config().unwrap(); | ||
Some(config.max_contract_limit as usize) | ||
} else { | ||
None | ||
Some(0x6000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use fn default_max_contract_limit
instead of hardcoding 0x6000?
What this PR does / why we need it?
This PR fixes evm config init with hardfork features
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description