-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change metadata system contract and add annotation #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
reviewed
Sep 26, 2023
4 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KaoImin
changed the title
style: change some code style and annotation
[WIP]style: change some code style and annotation
Oct 8, 2023
KaoImin
changed the title
[WIP]style: change some code style and annotation
refactor: change metadata system contract and add annotation
Oct 8, 2023
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
6 tasks
Flouse
reviewed
Oct 8, 2023
Flouse
previously approved these changes
Oct 8, 2023
Flouse
approved these changes
Oct 9, 2023
yangby-cryptape
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have different opinions, but since the deadline is already reached, I don't want to block the project progress.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
axon/core/executor/src/system_contract/mod.rs
Lines 130 to 131 in 8e5d567
axon/core/executor/src/system_contract/mod.rs
Line 134 in 8e5d567
metadata
precompile contractWhat is the impact of this PR?
No Breaking Change
PR relation:
ckb_light_client
andimage_cell
are saved into different MPT trie. #1441CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description