Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add version field to block header and proposal #1319

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Aug 14, 2023

What this PR does / why we need it:

This PR add version field to block header and proposal.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

Special notes for your reviewer:

⚠️This is a breaking change.

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner August 14, 2023 08:18
@KaoImin KaoImin requested review from jjyr and Simon-Tl August 14, 2023 08:18
@KaoImin KaoImin requested review from blckngm, driftluo and yangby-cryptape and removed request for jjyr and Simon-Tl August 14, 2023 08:19
@Flouse Flouse requested a review from jjyr August 14, 2023 08:26
@KaoImin KaoImin changed the title feat!: add block_version field to block feat!: add version field to block header and proposal Aug 14, 2023
@KaoImin

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@KaoImin

This comment was marked as off-topic.

@axon-bot
Copy link

axon-bot bot commented Aug 14, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Aug 15, 2023
Merged via the queue into main with commit e6c4f67 Aug 15, 2023
18 checks passed
@Flouse Flouse deleted the feat-block-version branch August 15, 2023 10:32
@Flouse Flouse removed the feature label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants