Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/onchain checks #18

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Feat/onchain checks #18

merged 10 commits into from
Mar 26, 2024

Conversation

amimart
Copy link
Member

@amimart amimart commented Mar 23, 2024

Implements the set of verification needed to accept an authentication VC.

Execution Order verification

The verification here only check the existence of such order extracting the zone id to feed to governance context, it'll be reworked once axone-protocol/ontology#261 is merged.

Governance check

Addition of the retrieval of the governance program linked to proxied storage service with the execution of it to allow or not the service:use action with the provided context.

It lacks the execution of the stored resources governances, this will be possible once axone-protocol/ontology#261 is merged.

@amimart amimart self-assigned this Mar 23, 2024
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few comments. I'll let you have a look.

app/handler.go Outdated Show resolved Hide resolved
dataverse/prolog.go Outdated Show resolved Hide resolved
dataverse/client.go Show resolved Hide resolved
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks ❤️

@amimart amimart merged commit def9fb3 into main Mar 26, 2024
9 of 11 checks passed
@amimart amimart deleted the feat/onchain-checks branch March 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants