Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(project): get rid of warning messages from Cargo #526

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Apr 2, 2024

This PR fixes the warnings emitted by Cargo during build:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

Summary by CodeRabbit

  • Chores
    • Updated project configuration for improved performance and stability.

@ccamel ccamel self-assigned this Apr 2, 2024
Copy link

coderabbitai bot commented Apr 2, 2024

Walkthrough

The recent update focuses on refining the project's build configuration within the Cargo.toml file. It introduces a new resolver version and tweaks settings related to code generation, debugging, optimization, and panic handling. Notably, it also removes several release profile configurations that pertained to these aspects, streamlining the build process and potentially impacting the project's compilation behavior and performance.

Changes

File(s) Change Summary
Cargo.toml Updated resolver version; adjusted codegen units, debug settings, optimization level, and panic behavior; removed specific release profile configurations.

🐰✨
To code, to build, a change we weave,
Through Cargo.toml, we achieve.
Debug, optimize, let panic flee,
In codegen units, our craft we see.
A hop, a skip, in binary spree,
Our project leaps, as free as can be.
✨🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (e4e894e) to head (d1632cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          56       56           
  Lines       13179    13179           
=======================================
  Hits        12704    12704           
  Misses        475      475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bot-anik
Copy link
Member

bot-anik commented Apr 2, 2024

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 394.44 KB (-11.3% 🔽)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 596.17 KB (-8.1% 🔽)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 759.8 KB (-9.08% 🔽)
target/wasm32-unknown-unknown/release/okp4_dataverse.wasm 620.88 KB (-7.95% 🔽)

@ccamel ccamel force-pushed the build/cargo-warnings branch from b25d412 to d1632cc Compare April 2, 2024 15:10
@ccamel ccamel marked this pull request as ready for review April 2, 2024 15:14
@ccamel ccamel requested a review from amimart April 2, 2024 15:14
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e4e894e and d1632cc.
Files selected for processing (5)
  • Cargo.toml (1 hunks)
  • contracts/okp4-cognitarium/Cargo.toml (1 hunks)
  • contracts/okp4-dataverse/Cargo.toml (1 hunks)
  • contracts/okp4-law-stone/Cargo.toml (1 hunks)
  • contracts/okp4-objectarium/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (2)
  • contracts/okp4-cognitarium/Cargo.toml
  • contracts/okp4-dataverse/Cargo.toml

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@ccamel ccamel merged commit 4b9ac2f into main Apr 3, 2024
18 checks passed
@ccamel ccamel deleted the build/cargo-warnings branch April 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants