Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust version to v1.71 #292

Closed
wants to merge 4 commits into from
Closed

Bump rust version to v1.71 #292

wants to merge 4 commits into from

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Jul 23, 2023

Self explanatory.

@ccamel ccamel self-assigned this Jul 23, 2023
@bot-anik
Copy link
Member

bot-anik commented Jul 23, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 399.85 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 634.46 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 757.15 KB (0%)

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #292 (beec4c4) into main (0f294af) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          41       41           
  Lines        8722     8723    +1     
=======================================
+ Hits         8547     8548    +1     
  Misses        175      175           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ccamel ccamel marked this pull request as ready for review July 23, 2023 16:21
@ccamel ccamel requested review from amimart and bdeneux July 23, 2023 16:21
@ErikssonJoakim ErikssonJoakim force-pushed the ci/bump-rust-version-1_71 branch 2 times, most recently from 60eb0fd to 066be2b Compare July 31, 2023 14:50
Copy link
Collaborator

@ErikssonJoakim ErikssonJoakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump it up 🥳

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 Unfortunately the current wasm vm ran in OKP4 blockchain doesn't support wasm opcode compiled in rust versions above 1.69, see: CosmWasm/cosmwasm#1727

By storing the compiled wasm through this branch we get the following error:

raw_log: 'failed to execute message; message index: 0: Error calling the VM: Error
  during static Wasm validation: Wasm bytecode could not be deserialized. Deserialization
  error: "Unknown opcode 192": create wasm contract failed'

To make it work we need to upgrade the wasm module to the v0.41.0 version on the okp4d node.

I propose to wait an upgrade for this purpose on the testnet with before merging, what do you think?

@ccamel
Copy link
Member Author

ccamel commented Aug 1, 2023

sob Unfortunately the current wasm vm ran in OKP4 blockchain doesn't support wasm opcode compiled in rust versions above 1.69, see: CosmWasm/cosmwasm#1727

By storing the compiled wasm through this branch we get the following error:

raw_log: 'failed to execute message; message index: 0: Error calling the VM: Error
  during static Wasm validation: Wasm bytecode could not be deserialized. Deserialization
  error: "Unknown opcode 192": create wasm contract failed'

To make it work we need to upgrade the wasm module to the v0.41.0 version on the okp4d node.

I propose to wait an upgrade for this purpose on the testnet with before merging, what do you think?

@amimart Oh! 😵 Good catch by the way. Thank goodness you tested it.

Alright, this makes me think about two things:

  • For the update, we should go for version v1.69, since that's the newest one that works, and it would be required by Feat/objectarium lzma compression #296.
  • We should set up some checks to make sure that the smart contracts still work in the chain. Honestly, it makes me a bit nervous to think that just changing the version of Rust could mess everything up.

Then, in a second phase, we will perform the version updates and upgrades as you have suggested.

@ccamel ccamel changed the title Bump rust version to v1.71 Bump rust version to v1.69 Aug 1, 2023
@ErikssonJoakim
Copy link
Collaborator

Renaming branch see #299

@ErikssonJoakim ErikssonJoakim deleted the ci/bump-rust-version-1_71 branch August 1, 2023 09:52
@amimart amimart changed the title Bump rust version to v1.69 Bump rust version to v1.71 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants