-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rust version to v1.71 #292
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 41 41
Lines 8722 8723 +1
=======================================
+ Hits 8547 8548 +1
Misses 175 175 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
60eb0fd
to
066be2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump it up 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭 Unfortunately the current wasm vm ran in OKP4 blockchain doesn't support wasm opcode compiled in rust versions above 1.69
, see: CosmWasm/cosmwasm#1727
By storing the compiled wasm through this branch we get the following error:
raw_log: 'failed to execute message; message index: 0: Error calling the VM: Error
during static Wasm validation: Wasm bytecode could not be deserialized. Deserialization
error: "Unknown opcode 192": create wasm contract failed'
To make it work we need to upgrade the wasm module to the v0.41.0 version on the okp4d node.
I propose to wait an upgrade for this purpose on the testnet with before merging, what do you think?
@amimart Oh! 😵 Good catch by the way. Thank goodness you tested it. Alright, this makes me think about two things:
Then, in a second phase, we will perform the version updates and upgrades as you have suggested. |
b4d7e02
to
b1c4499
Compare
b1c4499
to
beec4c4
Compare
Renaming branch see #299 |
Self explanatory.