Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪐 bump cosmos-sdk to 0.50.8 #698

Merged
merged 2 commits into from
Jul 22, 2024
Merged

🪐 bump cosmos-sdk to 0.50.8 #698

merged 2 commits into from
Jul 22, 2024

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jul 17, 2024

Nothing more to say... 😶

Summary by CodeRabbit

  • Chores
    • Updated dependencies to the latest versions for improved stability and performance.

Copy link
Contributor

coderabbitai bot commented Jul 17, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (4)
  • docs/command/axoned_keys_add.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_gov_proposals.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_wait-tx.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_multi-sign.md is excluded by !docs/command/**/*.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update focuses on upgrading dependencies in the go.mod file, primarily enhancing functionality and performance. Key updates include moving cometbft, cosmos-sdk, and gogoproto to newer versions, along with adding new libraries golang.org/x/exp and github.com/hashicorp/golang-lru/v2. These improvements aim to leverage the latest features and bug fixes offered by these packages, ensuring better stability and efficiency.

Changes

File Change Summary
go.mod Updated dependencies: cometbft from v0.38.7 to v0.38.9, cosmos-sdk from v0.50.6 to v0.50.8, gogoproto from v1.4.12 to v1.5.0. Added golang.org/x/exp v0.0.0-20240404231335-c0f41cb1a7a0 and github.com/hashicorp/golang-lru/v2 v2.0.7.

Poem

In the realm of Go, dependencies grow,
Updated versions, in a steady flow.
Cometbft and Cosmos rise,
With Gogoproto reaching for the skies.
New libraries join the quest,
For code that's sharp and at its best.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bdeneux bdeneux marked this pull request as ready for review July 17, 2024 14:00
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files          74       74           
  Lines        2896     2896           
=======================================
  Hits         1574     1574           
  Misses       1226     1226           
  Partials       96       96           

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0927eb8 and cfbc1b6.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Additional comments not posted (4)
go.mod (4)

27-27: Approved: Minor version bump for github.com/cosmos/cosmos-sdk.

This update from v0.50.6 to v0.50.8 likely includes critical bug fixes or performance improvements.

Verify for compatibility with related packages.


28-28: Approved: Minor version bump for github.com/cosmos/gogoproto.

This update from v1.4.12 to v1.5.0 might include new features or deprecations.

Verify for deprecated features or breaking changes.

Verification successful

No deprecated features or breaking changes found in the update from v1.4.12 to v1.5.0 of github.com/cosmos/gogoproto.

  • The release notes and the full CHANGELOG do not indicate any deprecated features or breaking changes.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the release notes for deprecated features or breaking changes between v1.4.12 and v1.5.0 of gogoproto.

# Test: Search GitHub for release notes.
gh release view v1.5.0 --repo github.com/cosmos/gogoproto

Length of output: 757


Script:

#!/bin/bash
# Description: Check the full CHANGELOG for deprecated features or breaking changes between v1.4.12 and v1.5.0 of gogoproto.

# Fetch the CHANGELOG from the repository and search for relevant keywords.
curl -s https://raw.githubusercontent.com/cosmos/gogoproto/main/CHANGELOG.md | grep -E 'deprecat|breaking'

Length of output: 108


24-24: Approved: Minor version bump for github.com/cometbft/cometbft.

This update from v0.38.7 to v0.38.9 likely includes bug fixes or minor enhancements.

Verify for any breaking changes.

Verification successful

Verified: The update to github.com/cometbft/cometbft v0.38.9 does not introduce new breaking changes.

The CHANGELOG confirms that the breaking change introduced in v0.38.8 has been reverted, and the Mempool interface is the same as in v0.38.7. Therefore, this update should be safe.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the release notes for breaking changes between v0.38.7 and v0.38.9 of cometbft.

# Test: Search GitHub for release notes.
gh release view v0.38.9 --repo github.com/cometbft/cometbft

Length of output: 758


Script:

#!/bin/bash
# Description: Fetch and display the CHANGELOG for cometbft v0.38.9 to check for breaking changes.

# Fetch the CHANGELOG for v0.38.9
curl -s https://raw.githubusercontent.com/cometbft/cometbft/v0.38.9/CHANGELOG.md | sed -n '/## v0.38.9/,/## v0.38.8/p'

Length of output: 921


56-56: Approved: Addition of new libraries golang.org/x/exp and github.com/hashicorp/golang-lru/v2.

These additions are likely intended to enhance functionality or performance.

Verify their integration and usage in the project.

Also applies to: 185-185

@bdeneux bdeneux requested review from ccamel and amimart July 17, 2024 15:05
@bdeneux bdeneux self-assigned this Jul 17, 2024
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks 🙏

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@amimart amimart merged commit 0702939 into main Jul 22, 2024
20 checks passed
@amimart amimart deleted the chore/bump-cosmos-sdk-0.50.8 branch July 22, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants