-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪐 bump cosmos-sdk
to 0.50.8
#698
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (4)
You can disable this status message by setting the WalkthroughThis update focuses on upgrading dependencies in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 54.35% 54.35%
=======================================
Files 74 74
Lines 2896 2896
=======================================
Hits 1574 1574
Misses 1226 1226
Partials 96 96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- go.mod (4 hunks)
Additional comments not posted (4)
go.mod (4)
27-27
: Approved: Minor version bump forgithub.com/cosmos/cosmos-sdk
.This update from
v0.50.6
tov0.50.8
likely includes critical bug fixes or performance improvements.Verify for compatibility with related packages.
28-28
: Approved: Minor version bump forgithub.com/cosmos/gogoproto
.This update from
v1.4.12
tov1.5.0
might include new features or deprecations.Verify for deprecated features or breaking changes.
Verification successful
No deprecated features or breaking changes found in the update from
v1.4.12
tov1.5.0
ofgithub.com/cosmos/gogoproto
.
- The release notes and the full CHANGELOG do not indicate any deprecated features or breaking changes.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the release notes for deprecated features or breaking changes between v1.4.12 and v1.5.0 of gogoproto. # Test: Search GitHub for release notes. gh release view v1.5.0 --repo github.com/cosmos/gogoprotoLength of output: 757
Script:
#!/bin/bash # Description: Check the full CHANGELOG for deprecated features or breaking changes between v1.4.12 and v1.5.0 of gogoproto. # Fetch the CHANGELOG from the repository and search for relevant keywords. curl -s https://raw.githubusercontent.com/cosmos/gogoproto/main/CHANGELOG.md | grep -E 'deprecat|breaking'Length of output: 108
24-24
: Approved: Minor version bump forgithub.com/cometbft/cometbft
.This update from
v0.38.7
tov0.38.9
likely includes bug fixes or minor enhancements.Verify for any breaking changes.
Verification successful
Verified: The update to
github.com/cometbft/cometbft
v0.38.9 does not introduce new breaking changes.The CHANGELOG confirms that the breaking change introduced in
v0.38.8
has been reverted, and theMempool
interface is the same as inv0.38.7
. Therefore, this update should be safe.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the release notes for breaking changes between v0.38.7 and v0.38.9 of cometbft. # Test: Search GitHub for release notes. gh release view v0.38.9 --repo github.com/cometbft/cometbftLength of output: 758
Script:
#!/bin/bash # Description: Fetch and display the CHANGELOG for cometbft v0.38.9 to check for breaking changes. # Fetch the CHANGELOG for v0.38.9 curl -s https://raw.githubusercontent.com/cometbft/cometbft/v0.38.9/CHANGELOG.md | sed -n '/## v0.38.9/,/## v0.38.8/p'Length of output: 921
56-56
: Approved: Addition of new librariesgolang.org/x/exp
andgithub.com/hashicorp/golang-lru/v2
.These additions are likely intended to enhance functionality or performance.
Verify their integration and usage in the project.
Also applies to: 185-185
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Nothing more to say... 😶
Summary by CodeRabbit