Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish): make docker hub publish work #643

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

amimart
Copy link
Member

@amimart amimart commented May 21, 2024

Set the correct configuration needed to publish on the new axoneprotocol docker hub organization.

Summary by CodeRabbit

  • Chores
    • Updated Docker image reference and repository information for publishing.
    • Modified Docker Hub description to reflect new repository details.

@amimart amimart requested review from ccamel and bdeneux May 21, 2024 09:54
@amimart amimart self-assigned this May 21, 2024
Copy link
Contributor

coderabbitai bot commented May 21, 2024

Walkthrough

The recent updates to the .github/workflows/publish.yml file focus on refining the Docker image reference and repository information for publishing. These changes include updating the image references and modifying the repository details to ensure accurate and current information is used during the Docker Hub Description step.

Changes

File Change Summary
.github/workflows/publish.yml Updated Docker image references and repository details for publishing, including changes to image reference, description, and repository information.

🌟 A Rabbit's Docker Delight 🌟
In the land of code, where changes flow,
We updated paths for Docker's glow.
With new repositories, fresh and bright,
Our images now take flight! 🚀
A tweak here, a change there,
For a publishing process beyond compare.
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amimart amimart force-pushed the ci/docker-publish branch from f3c07d4 to 09e0ddf Compare May 21, 2024 09:55
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e28ba17 and f3c07d4.
Files selected for processing (1)
  • .github/workflows/publish.yml (2 hunks)
Additional comments not posted (1)
.github/workflows/publish.yml (1)

77-79: LGTM! Verify that the dynamic repository reference in the description works as expected.

Verification successful

The dynamic repository reference in the Docker Hub description works as expected. The description field correctly updates based on the repository URL.

  • The description field uses the {{ .repository }} placeholder, ensuring it dynamically references the repository URL.
  • The simulation of a repository URL change confirmed that the description field updates accordingly.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the dynamic repository reference in the Docker Hub description.

# Test: Simulate a change in the repository field and check if the description updates accordingly.
echo "Simulating repository change..."
echo "New repository URL: https://github.com/axoneprotocol/axoned"

Length of output: 201



Script:

#!/bin/bash
# Description: Verify the dynamic repository reference in the Docker Hub description.

# Check the implementation of the dynamic reference in the workflow file.
echo "Inspecting the workflow file for dynamic reference implementation..."
grep -A 2 'description: Docker image for https://github.com/' .github/workflows/publish.yml

# Simulate a repository URL change and verify the description update.
echo "Simulating repository URL change..."
sed -i 's/axoneprotocol\/axoned/axoneprotocol\/new-repo/' .github/workflows/publish.yml
grep -A 2 'description: Docker image for https://github.com/' .github/workflows/publish.yml

Length of output: 863

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e28ba17 and 09e0ddf.
Files selected for processing (1)
  • .github/workflows/publish.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/publish.yml

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 👍

@amimart amimart merged commit 67e1082 into main May 21, 2024
19 checks passed
@amimart amimart deleted the ci/docker-publish branch May 21, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants