add mps support #1254
Closed
add mps support #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Feb 5, 2024
| from importlib.metadata import PackageNotFoundError, version | ||
|
|
||
| from packaging.version import Version, parse |
There was a problem hiding this comment.
If we're going to require packaging, we probably have to update the docs so people install this before axolotl. So we'll have to update the ci to install packaging too.
There was a problem hiding this comment.
We already do say to install packaging first in the readme
|
@maximegmd I can help with this PR, but because your PR is from your |
|
Replaced by #1264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports basic training on Mac M series.
Motivation and Context
It partially solves Mac support.
How has this been tested?
Ran a train job with lora-mps.yml from start to finish.