FilterX: fix invalid LogMessage variables access #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
11 times, most recently
from
e67d698
to
88b4238
Compare
OverOrion
changed the title
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
This is to better indicate the intention of synchronizing FilterX -> LogMessage. Signed-off-by: Szilard Parrag <[email protected]>
…rection Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
A non-floating (i.e., tied to a LogMessage) FilterX variable is considered invalid if: - its' generation counter is 0 AND - the scope is syncable This is to allow two consecutive FilterX blocks to pass non-floating variables without calling filterx_scope_sync(). If they would be considered invalid then the changes would be lost in the latter block. This is because it would fetch it via _pull_variable_from_message() which would yield the unmodified LogMessageValue. Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
from
88b4238
to
afd3f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes accessing
LogMessagetype FilterX variables in case there had been changes betweenfilterxblocks.