Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file(), stdout(): fix log sources getting stuck #303

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

MrAnno
Copy link
Member

@MrAnno MrAnno commented Sep 22, 2024

If a partial write occurs, the written messages must be acknowledged.

It is important to note that a message may be written partially.
In that case, the message will be acknowledged once the complete write is successful. If write errors occur during this process, the partially written message may be duplicated.

MrAnno added a commit to MrAnno/axosyslog that referenced this pull request Sep 22, 2024
Signed-off-by: László Várady <[email protected]>
@MrAnno MrAnno changed the title file-writer: fix partial write acknowledgements file(), stdout(): fix log sources getting stuck Sep 22, 2024
MrAnno added a commit to MrAnno/axosyslog that referenced this pull request Sep 22, 2024
Signed-off-by: László Várady <[email protected]>
Copy link
Member

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I had one small comment which you can ignore.

modules/affile/logproto-file-writer.c Show resolved Hide resolved
If a partial write occurs, the written messages must be acknowledged.

It is important to note that a message may be written partially.
In that case, the message will be acknowledged once the complete write
is successful. If write errors occur during this process, the partially
written message may be duplicated.

Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
@alltilla alltilla merged commit fcbb8c6 into axoflow:main Sep 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants