filterx: support casting datetime to integer or double #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Szakacs <[email protected]>
bazsi
reviewed
Sep 16, 2024
MrAnno
reviewed
Sep 19, 2024
| @@ -307,6 +308,10 @@ filterx_typecast_integer(FilterXExpr *s, GPtrArray *args) | |||
| return filterx_integer_new(val); | |||
| } | |||
|
|
|||
| UnixTime ut; | |||
| if (filterx_object_extract_datetime(object, &ut)) | |||
| return filterx_integer_new(ut.ut_sec * USEC_PER_SEC + ut.ut_usec); | |||
There was a problem hiding this comment.
Do we need microsecond precision? What's our use-case here, is this needed to send timestamps to somewhere where usec epoch is the required format or do we just need it for internal reasons?
If the former is the case, we would probably need a conversion function supporting multiple epoch precisions.
There was a problem hiding this comment.
I was thinking more in the other direction, e.g. using nanoseconds precision instead.
The conversion to msec or sec is simple, just divide it by 1000 or 1000000
I'd merge this as is and then maybe do a followup based on the result of the discussion.
MrAnno
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.