filterx: parse_windows_eventlog_xml()
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
force-pushed
the
filterx-windows-eventlog-xml
branch
5 times, most recently
from
ea13aac
to
ac65625
Compare
bazsi
reviewed
Sep 18, 2024
bazsi
reviewed
Sep 18, 2024
bazsi
reviewed
Sep 18, 2024
bazsi
reviewed
Sep 18, 2024
alltilla
force-pushed
the
filterx-windows-eventlog-xml
branch
2 times, most recently
from
a99b90d
to
055300f
Compare
|
@bazsi added the quick root node check as we discussed. |
alltilla
force-pushed
the
filterx-windows-eventlog-xml
branch
2 times, most recently
from
ebd6a1b
to
35a4e49
Compare
So we can descend from it. We should have an init_instance() function for the inheritance, but I ended it up not needing it for the parse_windows_eventlog_xml() function. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
To save a lot of allocations. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
filterx-windows-eventlog-xml
branch
from
35a4e49
to
4806f2e
Compare
bazsi
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do this cleanly with minimal code duplication, and this is what I could achieve. I am still not completely satisfied with the result, but I don't see how could this be improved without making it less clean.