transport: get rid of the TransportFactoryId abstraction and the associated registry #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
transport-remove-transport-registry
branch
from
a649cbe
to
08baf0b
Compare
…ciated registry TransportFactoryId was used to encapsulate a "name" and a unique identifier for each transport type, from which we had two: 1) socket 2) tls Since the switching between transports will only happen a couple of times within the lifetime of a connection, we don't need to optimize the lookup of the required transport to switch to. This patch simply changes the TransportFactoryId with a string and the lookup by ID to a lookup by string. The string identifiers are encapsulated in macros, so misspelling on the call sites is not likely. And we only have one single call site. By removing the TransportFactoryId and TransportFactoryRegistry I can easily get rid off 400 lines of complex, difficult to read code. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
transport-remove-transport-registry
branch
from
08baf0b
to
8efebf9
Compare
|
I've updated #156 to be based on top of this and finished off the conversion from LogProto to LogTransport when supporting the HAProxy protocol. |
MrAnno
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportFactoryId was used to encapsulate a "name" and a unique identifier for each transport type, from which we had two:
Since the switching between transports will only happen a couple of times within the lifetime of a connection, we don't need to optimize the lookup of the required transport to switch to.
This patch simply changes the TransportFactoryId with a string and the lookup by ID to a lookup by string. The string identifiers are encapsulated in macros, so misspelling on the call sites is not likely. And we only have one single call site.
By removing the TransportFactoryId and TransportFactoryRegistry I can easily get rid off 400 lines of complex, difficult to read code.