-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: factor out base classes for gRPC based drivers #276
Conversation
This Pull Request introduces config grammar changesaxoflow/8d8eab09d02508dfeddf1cdbc8fae5d783ef3489 -> alltilla/grpc-factor-out-common-classes --- a/destination
+++ b/destination
axosyslog-otlp(
+ keep-alive(
+ <empty>
+ max-pings-without-data(<nonnegative-integer>)
+ time(<nonnegative-integer>)
+ timeout(<nonnegative-integer>)
+ )
)
bigquery(
+ auth(
+ adc(<empty>)
+ alts(
+ <empty>
+ target-service-accounts(
+ <empty>
+ <string>
+ )
+ )
+ insecure(<empty>)
+ tls(
+ <empty>
+ ca-file(<string>)
+ cert-file(<string>)
+ key-file(<string>)
+ )
+ )
)
loki(
+ batch-bytes(<positive-integer>)
+ compression(<yesno>)
)
opentelemetry(
+ keep-alive(
+ <empty>
+ max-pings-without-data(<nonnegative-integer>)
+ time(<nonnegative-integer>)
+ timeout(<nonnegative-integer>)
+ )
)
syslog-ng-otlp(
+ keep-alive(
+ <empty>
+ max-pings-without-data(<nonnegative-integer>)
+ time(<nonnegative-integer>)
+ timeout(<nonnegative-integer>)
+ )
)
|
20aa005
to
7e51356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me get back to you with answers to your questions / requests.
Overall a solid looking PR, huge kudos for doing the extraction 💯
diff --git a/modules/grpc/common/Makefile.am b/modules/grpc/common/Makefile.am
index 541ba9f05..5c2cd99c6 100644
--- a/modules/grpc/common/Makefile.am
+++ b/modules/grpc/common/Makefile.am
@@ -3,7 +3,7 @@ include modules/grpc/common/metrics/Makefile.am
if ENABLE_GRPC
-noinst_LTLIBRARIES += modules/grpc/common/libgrpc-common.la
+lib_LTLIBRARIES += modules/grpc/common/libgrpc-common.la
GRPC_COMMON_CFLAGS = \
-I$(top_srcdir)/modules/grpc/common \ causes
|
faedca4
to
121be0c
Compare
Signed-off-by: Attila Szakacs <[email protected]>
121be0c
to
02559f1
Compare
Signed-off-by: Attila Szakacs <[email protected]>
02559f1
to
a0eb426
Compare
I think we shouldn't introduce more dynamic libraries around the gRPC drivers, we already have one (static linking seems more than okay in this specific case). |
Signed-off-by: Attila Szakacs <[email protected]>
a0eb426
to
d6d37f5
Compare
Fixed one review finding and rebased to main. |
Let's ask @mitzkia to check the compatibility of this PR next week (manually or in an automated way). |
Signed-off-by: Attila Szakacs <[email protected]>
d6d37f5
to
72e64bc
Compare
rebased to main |
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
@MrAnno I had to add some fixup commits that came from the manual E2E tests, could you kindly check them? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
…lasses Signed-off-by: Attila Szakacs <[email protected]>
…se classes Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
65d3bba
to
6b20819
Compare
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
With this a grammar file can load additional grammar files for declarations to use. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
6b20819
to
9413815
Compare
TODO:
For the reviewers:
grpc-common
target? I thought that dynamic linking would be better but I received a lot of linker warnings about it not being portable. Have I missed something?Is there a better way to merge two sets of keywords than defining a macro likeGRPC_KEYWORDS
? It messes up the cfg-helper :/gcc -E
and a bit of parsing improvement inaxosyslog-cfg-helper
will be able to handle this.