Fix race condition in FilterX simple funcs and perf improvements #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
force-pushed
the
fix-simple-func-race
branch
2 times, most recently
from
246f5f7
to
eeefc6c
Compare
MrAnno
force-pushed
the
fix-simple-func-race
branch
2 times, most recently
from
aa2cf22
to
26602d1
Compare
bshifter
reviewed
Aug 28, 2024
bshifter
previously approved these changes
Aug 29, 2024
This reverts commit fe5828f. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
This also fixes a race condition in _simple_eval(). Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
These are not thread-safe functions, but they would never be correctly used on a single thread (main thread) due to their nature, so removing them avoids confusion. Signed-off-by: László Várady <[email protected]>
This also fixes a race-condition related to the "retrieved" field of FilterXFunctionArgs. Signed-off-by: László Várady <[email protected]>
…reads Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-simple-func-race
branch
from
26602d1
to
e287dc2
Compare
bshifter
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 race conditions have been fixed around
FilterXFunctionArgs:retrievedfield should not be changed during evalref()/unref()calls should not be called during evalDepends on #252