Filterx parse csv refinements #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this still breaks the tests and it is indeed a bug (e.g. whitespace within quotation marks that should be stripped). don't merge yet. |
bazsi
force-pushed
the
filterx-parse-csv-refinements
branch
from
ace8875
to
0c08a80
Compare
bshifter
previously approved these changes
Jul 22, 2024
When the delimiter is either a space or a tab, and strip-whitespace is set, we don't want to remove those as whitespace, they may indicate an empty value. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…space The original argument was called this way. We still accept the plural version that we can get rid off. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-parse-csv-refinements
branch
from
0c08a80
to
0fe2636
Compare
|
@bshifter can you please re-approve? |
bshifter
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of csv parsing refinements: