Improve mktime cache #101
Merged
Improve mktime cache #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t present If the timestamp is not actually there in the message, we still tried to call convert_and_normalize_wall_clock_time_to_unix_time_with_tz_hint(), which in turn calls mktime(), which is a heavyweight operation. Let's not do that. Signed-off-by: Balazs Scheidler <[email protected]>
Without this patch, cached_mktime() produces a cached value for every second, and would call mktime() again as the second changes. This can be problematic when timestamps are parsed from different seconds in succession (e.g. when the syslog timestamp is 1 second away from a timestamp being parsed using strptime or date-parser). In these cases the cache was invalidated and mktime() was called again. mktime() is _slow_ as it even calls tzset() and validates that /etc/localtime is still pointing to the same timezone. This patch changes the caching strategy: - instead of specific seconds we calculate the cached value for the top of the hour (e.g. minutes==seconds==0) - timezones never change within the same hour, so as long as we are trying to use the cached value, we will do so as long as the year/month/day/hour value matches (plus isdst) - with this, mktime() will be called once every hour. If there's some fluctuation between subsequent timestamps at the turn of the hour, we can still exhibit limited caching (e.g. subsequent timestamps from the last hour and this one), but this is a lot better than the existing behaviour where we do that for every second. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
improve-mktime-cache
branch
from
d8aaffe
to
327acd4
Compare
alltilla
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the caching in cached_mktime() so that a single real mktime() invocation is valid for up to an hour.