App parser refactor #100
Merged
App parser refactor #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balazs Scheidler <[email protected]>
The entire app-parser() mechanism is undocumented as of now and I've looked at the users (our own scl and SC4S), neither is using it. I think this is a bad idea and just complicates the code anyway, so let's get rid of it. Signed-off-by: Balazs Scheidler <[email protected]>
In preparation for adding a new root-level object type, extract the abstract base object from Application. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
app-parser-refactor
branch
from
b91f15a
to
da0a0c1
Compare
alltilla
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the app-parser() and has the following changes:
it gets rid off the "*" topic, which basically allowed applications to register to all topics. This does not make much sense for me now, and as far as I understand noone is using it and is undocumented. The only big user is sc4s.
it creates the possibility to create app-parser() like entities by extracting an AppModelObject base class.
it has some refactors as well