feat: migrate dist.toml to dist-workspace.toml #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We treat dist.toml-alone generic projects a bit awkwardly because of our migration to the new metadata structure. The easiest solution for us is to migrate those proejcts to dist-workspace.toml, where they can be structured and interpreted the same as Cargo.toml projects with a dist-workspace.toml file.
Previously, we disallowed both [package] and [workspace] in a single dist-workspace.toml. However, we want to allow this for generic/non-Rust projects so that these users only need a single metadata file, not two. This required a few changes to axoproject in order to make sure we structure the data we're returning properly.
mistydemeo
force-pushed
the
migrate_dist_alone
branch
from
46ce241 to
29defea
Compare
duckinator
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treat dist.toml-alone generic projects a bit awkwardly because of our migration to the new metadata structure. The easiest solution for us is to migrate those proejcts to dist-workspace.toml, where they can be structured and interpreted the same as Cargo.toml projects with a dist-workspace.toml file.
Currently, this produces a pair ofdist-workspace.tomlanddist.toml. Thedist.tomlretains the package-level metadata, while thedist-workspace.tomlcontains a workspace entry with a singledist:.member and the[dist]metadata.At @ashleygwilliams's suggestion, I've updated axoproject so it now supports generic projects whose
dist-workspace.tomlcontains a[workspace]and[package]in the same file, and we produce that single metadata when migrating solo-dist.toml.