Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement config v0 -> v1 migration. #1653

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

[WIP, BROKEN] start making "dist init" use v1 config

bd40eca
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[WIP] Implement config v0 -> v1 migration. #1653

[WIP, BROKEN] start making "dist init" use v1 config
bd40eca
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Dec 20, 2024 in 0s

clippy

48 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 48
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 931 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `install_updater` on type `config::v1::TomlLayer`

error[E0609]: no field `install_updater` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:931:14
    |
931 |         meta.install_updater = Some(install_updater);
    |              ^^^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 910 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:910:14
    |
908 |           && meta
    |  ____________-
909 | |             .installers
910 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 907 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `install_updater` on type `config::v1::TomlLayer`

error[E0609]: no field `install_updater` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:907:18
    |
907 |     if orig_meta.install_updater.is_none()
    |                  ^^^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 901 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `publish_jobs` on type `config::v1::TomlLayer`

error[E0609]: no field `publish_jobs` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:901:10
    |
901 |     meta.publish_jobs = if publish_jobs.is_empty() {
    |          ^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
901 |     meta.publishers = if publish_jobs.is_empty() {
    |          ~~~~~~~~~~

Check failure on line 896 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `npm_scope` on type `config::v1::TomlLayer`

error[E0609]: no field `npm_scope` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:896:18
    |
896 |             meta.npm_scope = None;
    |                  ^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 892 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:892:14
    |
890 |           let npm_toggled_off = orig_meta
    |  _______________________________-
891 | |             .installers
892 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 884 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `npm_scope` on type `config::v1::TomlLayer`

error[E0609]: no field `npm_scope` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:884:22
    |
884 |                 meta.npm_scope = Some(scope.to_owned());
    |                      ^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 882 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `npm_scope` on type `config::v1::TomlLayer`

error[E0609]: no field `npm_scope` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:882:22
    |
882 |                 meta.npm_scope = None;
    |                      ^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 844 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:844:14
    |
842 |           let npm_is_new = !orig_meta
    |  ___________________________-
843 | |             .installers
844 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 837 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:837:10
    |
835 |       if meta
    |  ________-
836 | |         .installers
837 | |         .as_deref()
    | |_________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 829 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `tap` on type `config::v1::TomlLayer`

error[E0609]: no field `tap` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:829:18
    |
829 |             meta.tap = None;
    |                  ^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 825 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:825:14
    |
823 |           let homebrew_toggled_off = orig_meta
    |  ____________________________________-
824 | |             .installers
825 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 809 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `tap` on type `config::v1::TomlLayer`

error[E0609]: no field `tap` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:809:22
    |
809 |                 meta.tap = Some(tap.to_owned());
    |                      ^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 807 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `tap` on type `config::v1::TomlLayer`

error[E0609]: no field `tap` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:807:22
    |
807 |                 meta.tap = None;
    |                      ^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 784 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:784:14
    |
782 |           let homebrew_is_new = !orig_meta
    |  ________________________________-
783 | |             .installers
784 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 778 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:778:10
    |
776 |       if meta
    |  ________-
777 | |         .installers
778 | |         .as_deref()
    | |_________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 773 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `publish_jobs` on type `config::v1::TomlLayer`

error[E0609]: no field `publish_jobs` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:773:38
    |
773 |     let mut publish_jobs = orig_meta.publish_jobs.clone().unwrap_or(vec![]);
    |                                      ^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
773 |     let mut publish_jobs = orig_meta.publishers.clone().unwrap_or(vec![]);
    |                                      ~~~~~~~~~~

Check failure on line 730 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:730:18
    |
728 |               let config_had_it = meta
    |  _________________________________-
729 | |                 .installers
730 | |                 .as_deref()
    | |_________________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 931 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `install_updater` on type `config::v1::TomlLayer`

error[E0609]: no field `install_updater` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:931:14
    |
931 |         meta.install_updater = Some(install_updater);
    |              ^^^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 910 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:910:14
    |
908 |           && meta
    |  ____________-
909 | |             .installers
910 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 907 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `install_updater` on type `config::v1::TomlLayer`

error[E0609]: no field `install_updater` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:907:18
    |
907 |     if orig_meta.install_updater.is_none()
    |                  ^^^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 901 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `publish_jobs` on type `config::v1::TomlLayer`

error[E0609]: no field `publish_jobs` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:901:10
    |
901 |     meta.publish_jobs = if publish_jobs.is_empty() {
    |          ^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
901 |     meta.publishers = if publish_jobs.is_empty() {
    |          ~~~~~~~~~~

Check failure on line 896 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no field `npm_scope` on type `config::v1::TomlLayer`

error[E0609]: no field `npm_scope` on type `config::v1::TomlLayer`
   --> cargo-dist/src/init.rs:896:18
    |
896 |             meta.npm_scope = None;
    |                  ^^^^^^^^^ unknown field
    |
    = note: available fields are: `dist_version`, `dist_url_override`, `dist`, `allow_dirty`, `targets` ... and 6 others

Check failure on line 892 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied

error[E0599]: the method `as_deref` exists for enum `Option<InstallerLayer>`, but its trait bounds were not satisfied
   --> cargo-dist/src/init.rs:892:14
    |
890 |           let npm_toggled_off = orig_meta
    |  _______________________________-
891 | |             .installers
892 | |             .as_deref()
    | |_____________-^^^^^^^^
    |
   ::: cargo-dist/src/config/v1/installers/mod.rs:70:1
    |
70  |   pub struct InstallerLayer {
    |   ------------------------- doesn't satisfy `_: __Deref`
    |
    = note: the following trait bounds were not satisfied:
            `config::v1::installers::InstallerLayer: lazy_static::__Deref`
note: the trait `lazy_static::__Deref` must be implemented
   --> /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/deref.rs:136:1

Check failure on line 707 in cargo-dist/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `is_empty` found for reference `&config::v1::ci::CiLayer` in the current scope

error[E0599]: no method named `is_empty` found for reference `&config::v1::ci::CiLayer` in the current scope
   --> cargo-dist/src/init.rs:707:48
    |
707 |     let has_ci = meta.ci.as_ref().map(|ci| !ci.is_empty()).unwrap_or(false);
    |                                                ^^^^^^^^ method not found in `&CiLayer`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following traits define an item `is_empty`, perhaps you need to implement one of them:
            candidate #1: `axoasset::toml_edit::TableLike`
            candidate #2: `bitflags::traits::Flags`
            candidate #3: `gimli::read::reader::Reader`
            candidate #4: `nix::NixPath`
            candidate #5: `similar::DiffableStr`
            candidate #6: `std::iter::ExactSizeIterator`