feat: support XDG_CONFIG_HOME for receipts #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
respect_xdg_config_home
branch
from
573f1e2 to
698cb92
Compare
Gankra
previously requested changes
Sep 19, 2024
mistydemeo
force-pushed
the
respect_xdg_config_home
branch
2 times, most recently
from
4dbc6bb to
a21ae0a
Compare
We now check multiple receipt paths, including XDG_CONFIG_HOME. We load a receipt from the first path which contains a receipt file, ensuring we're able to manage the absence of a receipt in that path if that environment variable is set.
mistydemeo
force-pushed
the
respect_xdg_config_home
branch
from
a21ae0a to
81ffaaf
Compare
duckinator
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
This looks good to me.
I was going to suggest a test, but thinking about it a bit more, I think any test would basically be writing the exact logic a second time — and "this if/else if/else statement executes as the language says it should" is pretty much the same as assert!(true) // make sure booleans work. 😅
mistydemeo
force-pushed
the
respect_xdg_config_home
branch
7 times, most recently
from
b9726ce to
768bf0b
Compare
duckinator
approved these changes
Dec 19, 2024
mistydemeo
force-pushed
the
respect_xdg_config_home
branch
from
768bf0b to
4de5474
Compare
|
Ended up finding a real test I could write, so I've confirmed that this works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs axodotdev/cargo-dist#1355.
We'll need to make sure we ship the cargo-dist side as well when shipping this, so we don't get a mismatch in expectations.
An open question on this and the other PR: is it appropriate for us to respect this on both Linux and Mac? I'm assuming yes.
cc @brennanfee