Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a list, not a tuple, for authentication_classes #668

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Use a list, not a tuple, for authentication_classes #668

merged 2 commits into from
Oct 31, 2020

Conversation

brianhelba
Copy link
Contributor

DRF expects authentication classes to be in a list: https://www.django-rest-framework.org/api-guide/authentication/

Semantically, this should be a list, as the number of elements is arbitrary.

@brianhelba
Use a list, not a tuple, for authentication_classes
92b7ec8 
DRF expects authentication classes to be in a list:
https://www.django-rest-framework.org/api-guide/authentication/

Semantically, this should be a list, as the number of elements is arbitrary.
@brianhelba
Copy link
Contributor Author

This has a minor conflict with #666, since they touch adjacent lines. If accepted, please merge #666 first. I'll rebase this to fix any conflicts afterwards.

@axnsan12 axnsan12 merged commit b99306f into axnsan12:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhelba @axnsan12