Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawNode V2 #2124

Merged
merged 13 commits into from
Sep 6, 2024
Merged

DrawNode V2 #2124

merged 13 commits into from
Sep 6, 2024

Conversation

aismann
Copy link
Contributor

@aismann aismann commented Sep 1, 2024

Describe your changes

Add all review parts.
Please review again. Thanks.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@aismann aismann marked this pull request as draft September 1, 2024 10:27
@aismann aismann marked this pull request as ready for review September 1, 2024 11:27
@aismann
Copy link
Contributor Author

aismann commented Sep 1, 2024

@smilediver, @halx99
Please review again. Thanks.

@halx99
Copy link
Collaborator

halx99 commented Sep 1, 2024

the 2nd test of Node:Draw will crash on android devices, and follow test has flick problem on android devices:
Screenshot_2024-09-01-22-33-11-177_org axmol cpp_tests

@halx99
Copy link
Collaborator

halx99 commented Sep 1, 2024

just download cpp-test apk from this PR latest build artifacts will reproduce above problems:

https://github.com/axmolengine/axmol/actions/runs/10653604025/artifacts/1879283194

@aismann
Copy link
Contributor Author

aismann commented Sep 1, 2024

just download cpp-test apk from this PR latest build artifacts will reproduce above problems:

https://github.com/axmolengine/axmol/actions/runs/10653604025/artifacts/1879283194

I think its the tester itself which be not stable.
I will look.

@aismann aismann marked this pull request as draft September 1, 2024 19:41
@halx99
Copy link
Collaborator

halx99 commented Sep 2, 2024

the 2nd test of Node:Draw will crash on android devices, and follow test has flick problem on android devices: Screenshot_2024-09-01-22-33-11-177_org axmol cpp_tests

The original draw node works well

@aismann
Copy link
Contributor Author

aismann commented Sep 2, 2024

@halx99
Can you check the android issue again?
I will check it at home later

tests/cpp-tests/Source/DrawNodeTest/DrawNodeTest.cpp Outdated Show resolved Hide resolved
tests/cpp-tests/Source/DrawNodeTest/DrawNodeTest.cpp Outdated Show resolved Hide resolved
tests/cpp-tests/Source/DrawNodeTest/DrawNodeTest.cpp Outdated Show resolved Hide resolved
@halx99
Copy link
Collaborator

halx99 commented Sep 2, 2024

Could you also preserve old DrawNodeTests?

@aismann
Copy link
Contributor Author

aismann commented Sep 2, 2024

Could you also preserve old DrawNodeTests?

Sure.
But the most be no longer usefull

@halx99
Copy link
Collaborator

halx99 commented Sep 3, 2024

Could you also preserve old DrawNodeTests?

Sure. But the most be no longer usefull

I just want to see all old tests works well

@aismann aismann marked this pull request as ready for review September 3, 2024 07:18
@halx99
Copy link
Collaborator

halx99 commented Sep 3, 2024

This test seems dead loop on android device:
Screenshot_2024-09-04-00-46-21-107_org axmol cpp_tests

@aismann aismann marked this pull request as draft September 3, 2024 19:12
@aismann
Copy link
Contributor Author

aismann commented Sep 4, 2024

@halx99
Can you test it again?
Here on my device its works well (used: build / android (armv7))

@aismann aismann marked this pull request as ready for review September 4, 2024 09:55
@halx99
Copy link
Collaborator

halx99 commented Sep 4, 2024

This test seems dead loop on android device: Screenshot_2024-09-04-00-46-21-107_org axmol cpp_tests

issue still exist, when I goto the test, I can't get any response when I click any button

@aismann
Copy link
Contributor Author

aismann commented Sep 4, 2024

This test seems dead loop on android device: Screenshot_2024-09-04-00-46-21-107_org axmol cpp_tests

issue still exist, when I goto the test, I can't get any response when I click any button

armv7 also?

@halx99
Copy link
Collaborator

halx99 commented Sep 4, 2024

This test seems dead loop on android device: Screenshot_2024-09-04-00-46-21-107_org axmol cpp_tests

issue still exist, when I goto the test, I can't get any response when I click any button

armv7 also?

Yes

@aismann
Copy link
Contributor Author

aismann commented Sep 4, 2024

Can you try to reduce the sizes?
static float WID = 400;
static float HIG = 600

I will remove this test from android devices

WID is also on renderline again

@aismann aismann marked this pull request as draft September 4, 2024 16:48
@aismann aismann marked this pull request as ready for review September 5, 2024 04:38
@aismann
Copy link
Contributor Author

aismann commented Sep 5, 2024

@halx99
Please review again. its all done and ready for merge

@halx99 halx99 added this to the 2.2.0 milestone Sep 6, 2024
@halx99 halx99 merged commit 4ae3792 into axmolengine:dev Sep 6, 2024
15 checks passed
@halx99
Copy link
Collaborator

halx99 commented Sep 16, 2024

xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
* DrawNodeV2 ready4merge

* Update README.md

* Lua stuff

* Update DrawNode.h

* Update DrawNode.cpp

* Update DrawNode.cpp

* Update DrawNode.cpp

* Add the cocos2dx test again, add some improvements

* Some improvements

* Remove CandyMix from Android devices

* Update DrawNodeTest.cpp

* Clean tester code
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
* DrawNodeV2 ready4merge

* Update README.md

* Lua stuff

* Update DrawNode.h

* Update DrawNode.cpp

* Update DrawNode.cpp

* Update DrawNode.cpp

* Add the cocos2dx test again, add some improvements

* Some improvements

* Remove CandyMix from Android devices

* Update DrawNodeTest.cpp

* Clean tester code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants