-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DrawNode V2 #2124
DrawNode V2 #2124
Conversation
@smilediver, @halx99 |
just download cpp-test apk from this PR latest build artifacts will reproduce above problems: https://github.com/axmolengine/axmol/actions/runs/10653604025/artifacts/1879283194 |
I think its the tester itself which be not stable. |
@halx99 |
Could you also preserve old DrawNodeTests? |
Sure. |
I just want to see all old tests works well |
@halx99 |
Can you try to reduce the sizes? I will remove this test from android devices WID is also on renderline again |
@halx99 |
@aismann does the folder https://github.com/axmolengine/axmol/tree/dev/extensions/DrawNodeEx/ can be deleted? |
* DrawNodeV2 ready4merge * Update README.md * Lua stuff * Update DrawNode.h * Update DrawNode.cpp * Update DrawNode.cpp * Update DrawNode.cpp * Add the cocos2dx test again, add some improvements * Some improvements * Remove CandyMix from Android devices * Update DrawNodeTest.cpp * Clean tester code
* DrawNodeV2 ready4merge * Update README.md * Lua stuff * Update DrawNode.h * Update DrawNode.cpp * Update DrawNode.cpp * Update DrawNode.cpp * Add the cocos2dx test again, add some improvements * Some improvements * Remove CandyMix from Android devices * Update DrawNodeTest.cpp * Clean tester code
Describe your changes
Add all review parts.
Please review again. Thanks.
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR