Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix ImGui usage crash due to invalid pointer #1920

Merged
merged 1 commit into from
May 22, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented May 22, 2024

Describe your changes

This will fix the crash due to the assert statement in ImGui::Shutdown:
IM_ASSERT_USER_ERROR(g.IO.BackendRendererUserData == NULL, "Forgot to shutdown Renderer backend?");

The IO.BackendRendererUserData either contains the same value as IO.BackendPlatformUserData or NULL.

Issue ticket number and link

#1915

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added the bug Something isn't working label May 22, 2024
@halx99 halx99 added this to the 2.1.3 milestone May 22, 2024
@halx99 halx99 linked an issue May 22, 2024 that may be closed by this pull request
@halx99 halx99 merged commit db1b022 into axmolengine:dev May 22, 2024
15 checks passed
@rh101 rh101 deleted the imgui-android-crash-fix branch May 23, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak (and crash) in ImGui_ImplAndroid_Shutdown()
2 participants