Improve the default templates (at least the cpp template) #1494

aismann · 2023-12-10T01:42:04Z

Which branch your pull-request should merge into?

dev: Current 2.x BugFixs or Features

Describe your changes

see #1493 and diff

Issue ticket number and link

#1493

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.
I have checked readme and add important infos to this PR (if it needed).
I have added/adapted some tests too.

aismann · 2023-12-10T07:54:55Z

@halx99 ,
Merging this PR can be the startpoint for the single template with Lua/CPP

templates/cpp-template-default/Source/MainScene.cpp

templates/cpp-template-default/Source/MainScene.h

paulocoutinhox · 2023-12-10T08:32:11Z

To me this PR make sense, but the name CPPTemplate is horrible to me. You put CPPTemplate everywhere.

Other problem is that changing only this package/bundle dont work, because org.axmol.hellocpp is replaced in other places in axproj-template.json.

Between CPPTemplate and hellocpp i prefer hellocpp.

Other thing is that you need follow the cases where it is lowecase and uppercase.

aismann · 2023-12-10T08:53:15Z

To me this PR make sense, but the name CPPTemplate is horrible to me. You put CPPTemplate everywhere.

Other problem is that changing only this package/bundle dont work, because org.axmol.hellocpp is replaced in other places in axproj-template.json.

Between CPPTemplate and hellocpp i prefer hellocpp.

Other thing is that you need follow the cases where it is lowecase and uppercase.

Why is 'hellocpp' better?

rh101 · 2023-12-10T09:15:18Z

@aismann As @paulocoutinhox mentioned in his post, the "HelloCpp" and "hellocpp" are placeholders that are replaced when a new Axmol project is created. If you're going to update the name of the project to "CPPTemplate", then you must also change this file to make sure it can look up the correct strings for replacement:

https://github.com/axmolengine/axmol/blob/dev/templates/cpp-template-default/axproj-template.json

paulocoutinhox · 2023-12-10T09:24:16Z

And if you want to change HelloCpp, I suggest you use a better and more definitive name then, like "AxmolCpp". Something that doesn't look like a hello world or template. I think it's strange to have something written "template" in my project right away.

rh101 · 2023-12-10T09:26:24Z

And if you want to change HelloCpp, I suggest you use a better and more definitive name then, like "AxmolCpp". Something that doesn't look like a hello world or template. I think it's strange to have something written "template" in my project right away.

Please avoid using the word "Axmol" in the project name, or anything that needs to be replaced, as it makes it more difficult to search for that string, since so much has "Axmol" in it already.

In fact, there is nothing wrong with HelloCpp at all. It's a placeholder, and as such, it is always going to be replaced by the developer, so all it needs to be is unique enough to notice, and easy enough to search for.

Also, has anyone ever actually logged an issue related to "HelloCpp", and I don't mean an issue related to personal preference, but a specific concern or technical issue about its usage? If not, then perhaps putting much focus on changing it is of no real benefit to developers using Axmol.

aismann · 2023-12-10T09:33:19Z

And if you want to change HelloCpp, I suggest you use a better and more definitive name then, like "AxmolCpp". Something that doesn't look like a hello world or template. I think it's strange to have something written "template" in my project right away.

'CPPTemplate/HelloCpp' will be replaced on axmol new...
'CPPTemplate/HelloCpp' are only placeholders and will add cpp-template-default into project(axmol) for tmp test on e.g.: VSStudio.

Also, has anyone ever actually logged an issue related to "HelloCpp", and I don't mean an issue related to personal preference, but a specific concern or technical issue about its usage? If not, then perhaps putting much focus on changing it is of no real benefit to developers using Axmol.

My reason to rename 'HelloCpp' is:

paulocoutinhox · 2023-12-10T09:36:53Z

Cannot be "CppProject", "MyProject", "MyApp", "CppApp", something more beautiful?

aismann · 2023-12-10T09:37:44Z

Cannot be "CppProject", "MyProject", "MyApp", "CppApp", something more beautiful?

No. Its only for:
add cpp-template-default into project(axmol) for tmp test
=> NOT for your project (which is mostly wrong used of course)
Hint: Changing anything on 'HellpCpp/HelloLua' had changed also the template itself on your axmol folder

paulocoutinhox · 2023-12-10T09:47:44Z

The problem is that you are changing everything for CPP, you need do like me on latests PR, that is change for BOTH templates.

You changing all for this, but lua template follow the same pattern, ex: HelloLua, org.axmol.hellolua.

The more you keep messing with it, the harder it is to maintain two templates. I've already spent a lot of time adjusting both projects and now you're going to make them different again.

aismann · 2023-12-10T09:50:13Z

The more you keep messing with it, the harder it is to maintain two templates. I've already spent a lot of time adjusting both projects and now you're going to make them different again.

Sorry. you should not using axmol which is continues improving ;)
@paulocoutinhox if you familiar with Lua maybe you can write a PR which makes one template for cpp/lua (using this PR as start point)?

rh101 · 2023-12-10T10:02:36Z

Sorry. you should not using axmol which is contininus improving ;)

Improvements to Axmol are great, but, in order for developers to use Axmol, it needs to be relatively stable, in terms of frequency of changes, and the impact that the changes have. Stating that a developer should not be using Axmol because it's continuously improving is actually a negative, not a positive, and perhaps a little inappropriate too, don't you think?

aismann · 2023-12-10T10:10:32Z

Sorry. you should not using axmol which is contininus improving ;)

Improvements to Axmol are great, but, in order for developers to use Axmol, it needs to be relatively stable, in terms of frequency of changes, and the impact that the changes have. Stating that a developer should not be using Axmol, because it's continuously improving is actually a negative, not a positive, and perhaps a little inappropriate too, don't you think?

No I think not. Everybody can use own projects which was created before whithout an effect there.
A new template is part of the improvement of axmol. A sentence like I've already spent a lot of time adjusting both projects and now you're going to make them different again is funny.

Sorry. you should not using axmol which is contininus improving ;)

Was also mean as a funny sentence of course (look on the smiley)

aismann · 2023-12-10T13:19:11Z

@halx99
Im finished, Can be merged.

aismann · 2023-12-10T22:34:39Z

Ok. I see neverone understand what 'HelloCpp' realy is:
Its not an one project!
Its always using the sources of cpp-default-template.
So CPPTemplate is more correct.
Btw changing anything on 'HelloCpp' was always changing the cpp-default-template content not a 'HelloCpp' stuff.
An old Cocos2d-x mistake which will be correct now.
Thats my point of view

halx99 · 2023-12-10T23:13:03Z

I perfer HelloCpp, a real project name can be build & test

…

________________________________ From: aismann ***@***.***> Sent: Sunday, December 10, 2023 9:19:22 PM To: axmolengine/axmol ***@***.***> Cc: Deal ***@***.***>; Mention ***@***.***> Subject: Re: [axmolengine/axmol] Improve the default templates (at least the cpp template) (PR #1494) @halx99<https://github.com/halx99> Im finished, Can be merged. — Reply to this email directly, view it on GitHub<#1494 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVHOJ2UKBRXQX4IK2AHXW3YIWZFVAVCNFSM6AAAAABAOGDWZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHE3DGNRYGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

aismann · 2023-12-10T23:30:23Z

HelloCpp lets developer meaning thats an own project and not the template itself.

HelloCpp should never used as a full project.
See the comment on CMakeList too:
add cpp-template-default into project(axmol) for tmp test

axmol new... wil be affected

rh101 · 2023-12-10T23:48:13Z

@aismann I'm sure everyone understands that it is just a temporary project name for the template and nothing more. There is no need to force the issue.

There are a number of items in this PR that are actual good to change, such as the HelloWorldScene change to MainScene etc., so best to enable them to be merged in sooner rather than later by limiting this PR to only those useful changes for now.

The project name change can be given more consideration, and can always be changed in a future PR if the need arises.

templates/cpp-template-default/Source/AppDelegate.cpp

aismann · 2023-12-11T00:38:36Z

Should be ready for merge now

replace HelloCpp* with CPPTemplate

fed2023

paulocoutinhox reviewed Dec 10, 2023

View reviewed changes

templates/cpp-template-default/Source/MainScene.cpp Outdated Show resolved Hide resolved

paulocoutinhox reviewed Dec 10, 2023

View reviewed changes

templates/cpp-template-default/Source/MainScene.h Outdated Show resolved Hide resolved

paulocoutinhox reviewed Dec 10, 2023

View reviewed changes

templates/cpp-template-default/Source/MainScene.h Outdated Show resolved Hide resolved

aismann added 2 commits December 10, 2023 09:56

fix typos

312257a

use org.axmol.cpptemplate

9b64909

Update axproj-template.json

fe81ce3

aismann added 5 commits December 11, 2023 00:59

rename CPpTemplate to HelloWorld or Hello World

e1bd360

@aismann rename CPpTemplate to HelloCpp

be59569

Update axproj-template.json

d848cc9

Update build.ps1

e6deeac

Update CMakeLists.txt

9255c65

aismann added 2 commits December 11, 2023 01:24

Update AppDelegate.cpp

e9bb3b3

Update AppDelegate.cpp

9e41377

rh101 reviewed Dec 11, 2023

View reviewed changes

templates/cpp-template-default/Source/AppDelegate.cpp Outdated Show resolved Hide resolved

aismann added 5 commits December 11, 2023 01:28

use HelloWorld.png again

75e7f94

Update AppDelegate.cpp

5b6fed7

Update AppDelegate.cpp

66dc0f5

Update MainScene.cpp

d18d61d

Update MainScene.cpp

2e4fd7c

halx99 linked an issue Dec 11, 2023 that may be closed by this pull request

Improve the default templates (at least the cpp template) #1493

Closed

halx99 approved these changes Dec 11, 2023

View reviewed changes

halx99 added this to the 2.1.0-LTS milestone Dec 11, 2023

halx99 added the enhancement New feature or request label Dec 11, 2023

halx99 merged commit 62e6542 into axmolengine:dev Dec 11, 2023
9 checks passed

aismann deleted the improve-CPPTemplate branch December 11, 2023 06:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve the default templates (at least the cpp template) #1494

Improve the default templates (at least the cpp template) #1494

aismann commented Dec 10, 2023

aismann commented Dec 10, 2023 •

edited

Loading

paulocoutinhox commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023

rh101 commented Dec 10, 2023 •

edited

Loading

paulocoutinhox commented Dec 10, 2023

rh101 commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

paulocoutinhox commented Dec 10, 2023

aismann commented Dec 10, 2023 •

edited

Loading

paulocoutinhox commented Dec 10, 2023

aismann commented Dec 10, 2023 •

edited

Loading

rh101 commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023

aismann commented Dec 10, 2023 •

edited

Loading

halx99 commented Dec 10, 2023 via email

aismann commented Dec 10, 2023 •

edited

Loading

rh101 commented Dec 10, 2023

aismann commented Dec 11, 2023

Improve the default templates (at least the cpp template) #1494

Improve the default templates (at least the cpp template) #1494

Conversation

aismann commented Dec 10, 2023

Describe your changes

Issue ticket number and link

Checklist before requesting a review

aismann commented Dec 10, 2023 • edited Loading

paulocoutinhox commented Dec 10, 2023 • edited Loading

aismann commented Dec 10, 2023

rh101 commented Dec 10, 2023 • edited Loading

paulocoutinhox commented Dec 10, 2023

rh101 commented Dec 10, 2023 • edited Loading

aismann commented Dec 10, 2023 • edited Loading

paulocoutinhox commented Dec 10, 2023

aismann commented Dec 10, 2023 • edited Loading

paulocoutinhox commented Dec 10, 2023

aismann commented Dec 10, 2023 • edited Loading

rh101 commented Dec 10, 2023 • edited Loading

aismann commented Dec 10, 2023 • edited Loading

aismann commented Dec 10, 2023

aismann commented Dec 10, 2023 • edited Loading

halx99 commented Dec 10, 2023 via email

aismann commented Dec 10, 2023 • edited Loading

rh101 commented Dec 10, 2023

aismann commented Dec 11, 2023

aismann commented Dec 10, 2023 •

edited

Loading

paulocoutinhox commented Dec 10, 2023 •

edited

Loading

rh101 commented Dec 10, 2023 •

edited

Loading

rh101 commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

rh101 commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading

aismann commented Dec 10, 2023 •

edited

Loading