Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkReallySupportsASTC does not work on ios device #2078

Closed
BIGCATDOG opened this issue Aug 8, 2024 · 6 comments
Closed

checkReallySupportsASTC does not work on ios device #2078

BIGCATDOG opened this issue Aug 8, 2024 · 6 comments
Labels
bug Something isn't working
Milestone
2.1.5

Comments

@BIGCATDOG
Copy link

  • axmol version: latest version
  • devices test on:iPhone XR
  • developing environments
    • NDK version: r23c
    • Xcode version: 15.1
    • Visual Studio:
      • VS version: 2022 (17.9+)
      • MSVC version: 19.39+
      • Windows SDK version: 10.0.22621.0+
    • cmake version:
      Steps to Reproduce:
  1. glReadPixels always get black pixel so that checkReallySupportsASTC return false.
@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2024 •
edited
Loading

by default ios use metal render backend, not GLES, do you means GLES? if so that should really means ios GLES render not support ASTC

@BIGCATDOG
Copy link
Author

yes, i use GLES render backend.

@BIGCATDOG
Copy link
Author

And it works perfect on android device. It is strange.

@BIGCATDOG
Copy link
Author

BIGCATDOG commented Aug 8, 2024 •
edited
Loading

@halx99 If i just hard code to make check function return true. Everything works well. ASTC texture can be rendered on screen on ios device.

@halx99 halx99 added the help wanted Extra attention is needed label Aug 8, 2024
@halx99 halx99 added this to the 2.1.5 milestone Aug 8, 2024
@halx99 halx99 added bug Something isn't working and removed help wanted Extra attention is needed labels Aug 8, 2024
halx99 added a commit that referenced this issue Aug 8, 2024
@halx99
Fix checkReallySupportsASTC does not work on ios device
17b2088 
reported by @BIGCATDOG in #2078
@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2024 •
edited
Loading

should fixed by commits in branch https://github.com/axmolengine/axmol/tree/release-2.1.5

@halx99 halx99 closed this as completed Aug 8, 2024
@BIGCATDOG
Copy link
Author

should fixed by commits in branch https://github.com/axmolengine/axmol/tree/release-2.1.5
It is very appreciated. Thanks for your hard work.

halx99 added a commit that referenced this issue Aug 11, 2024
@halx99 @danialias
@aismann @smilediver
Release 2.1.5 (#2076)
3471594 
* Fix  unexpected libpng used

* Fix string format incorrect for tests

* Fix #1751, use coroutine control AutoTest flow

* Update CHANGELOG.md

* Added OpenType font (.otf) to the noCompress list. (#2077)

* Update 1k & copyright notice in some sources

* Move doctest to axmol 3rdparty

* Fix ci

* Update 1kdist to v90

* Update 1kiss.ps1

* DrawNodeV2 0.95.1 (#2079)

* Rename remaining legacy engine related spells and improve code style

* Update 3rdparty README.md

* Fix checkReallySupportsASTC does not work on ios device

reported by @BIGCATDOG in #2078

* Fix ci

* FastRNG: add missing include for AXASSERT (#2081)

* Delete unused files

* Improve FileUtils

- Rename FileUtils::createDirectory to FileUtils::createDirectories
- Use splitpath_cb to optimize FileUtils::createDirectories
- Rename FileUtils::getFileShortName to FileUtils::getPathBaseName
- Rename FileUtils::getFileExtension to FileUtils::getPathExtension
- Add FileUtils::getPathDirName
- Add FileUtils::getPathBaseNameNoExtension
- Mark all renamed FileUtils stubs old name deprecated
- Mark all FileUtils offthread APIs deprecated

* Update box2d to v2.4.2

* Disable /sdl checks explicitly for winuwp

For axmol deprecated policy, we need disable /sdl checks explicitly to avoid compiler traits invoking deprecated functions as error

* Update cppwinrt to 2.0.240405.15

* Update simdjson to 3.10.0

* Fix box2d testbed compile error

* Improve file path to url

* Fix FileUtils::createDirectories unix logic

* axmol-cmdline: remove arch suffix for host build output directory

* Update CHANGELOG.md [skip ci]

---------

Co-authored-by: Dani Alias <[email protected]>
Co-authored-by: aismann <[email protected]>
Co-authored-by: smilediver <[email protected]>
halx99 added a commit that referenced this issue Aug 11, 2024
@halx99 @danialias
@aismann @smilediver
Release 2.1.5 (#2076)
92005fb 
* Fix  unexpected libpng used

* Fix string format incorrect for tests

* Fix #1751, use coroutine control AutoTest flow

* Update CHANGELOG.md

* Added OpenType font (.otf) to the noCompress list. (#2077)

* Update 1k & copyright notice in some sources

* Move doctest to axmol 3rdparty

* Fix ci

* Update 1kdist to v90

* Update 1kiss.ps1

* DrawNodeV2 0.95.1 (#2079)

* Rename remaining legacy engine related spells and improve code style

* Update 3rdparty README.md

* Fix checkReallySupportsASTC does not work on ios device

reported by @BIGCATDOG in #2078

* Fix ci

* FastRNG: add missing include for AXASSERT (#2081)

* Delete unused files

* Improve FileUtils

- Rename FileUtils::createDirectory to FileUtils::createDirectories
- Use splitpath_cb to optimize FileUtils::createDirectories
- Rename FileUtils::getFileShortName to FileUtils::getPathBaseName
- Rename FileUtils::getFileExtension to FileUtils::getPathExtension
- Add FileUtils::getPathDirName
- Add FileUtils::getPathBaseNameNoExtension
- Mark all renamed FileUtils stubs old name deprecated
- Mark all FileUtils offthread APIs deprecated

* Update box2d to v2.4.2

* Disable /sdl checks explicitly for winuwp

For axmol deprecated policy, we need disable /sdl checks explicitly to avoid compiler traits invoking deprecated functions as error

* Update cppwinrt to 2.0.240405.15

* Update simdjson to 3.10.0

* Fix box2d testbed compile error

* Improve file path to url

* Fix FileUtils::createDirectories unix logic

* axmol-cmdline: remove arch suffix for host build output directory

* Update CHANGELOG.md

* Update lua bindings

---------

Co-authored-by: Dani Alias <[email protected]>
Co-authored-by: aismann <[email protected]>
Co-authored-by: smilediver <[email protected]>
halx99 added a commit that referenced this issue Aug 11, 2024
@halx99 @danialias
@aismann @smilediver
Release 2.1.5 (#2076)
b25b702 
* Fix  unexpected libpng used

* Fix string format incorrect for tests

* Fix #1751, use coroutine control AutoTest flow

* Update CHANGELOG.md

* Added OpenType font (.otf) to the noCompress list. (#2077)

* Update 1k & copyright notice in some sources

* Move doctest to axmol 3rdparty

* Fix ci

* Update 1kdist to v90

* Update 1kiss.ps1

* DrawNodeV2 0.95.1 (#2079)

* Rename remaining legacy engine related spells and improve code style

* Update 3rdparty README.md

* Fix checkReallySupportsASTC does not work on ios device

reported by @BIGCATDOG in #2078

* Fix ci

* FastRNG: add missing include for AXASSERT (#2081)

* Delete unused files

* Improve FileUtils

- Rename FileUtils::createDirectory to FileUtils::createDirectories
- Use splitpath_cb to optimize FileUtils::createDirectories
- Rename FileUtils::getFileShortName to FileUtils::getPathBaseName
- Rename FileUtils::getFileExtension to FileUtils::getPathExtension
- Add FileUtils::getPathDirName
- Add FileUtils::getPathBaseNameNoExtension
- Mark all renamed FileUtils stubs old name deprecated
- Mark all FileUtils offthread APIs deprecated

* Update box2d to v2.4.2

* Disable /sdl checks explicitly for winuwp

For axmol deprecated policy, we need disable /sdl checks explicitly to avoid compiler traits invoking deprecated functions as error

* Update cppwinrt to 2.0.240405.15

* Update simdjson to 3.10.0

* Fix box2d testbed compile error

* Improve file path to url

* Fix FileUtils::createDirectories unix logic

* axmol-cmdline: remove arch suffix for host build output directory

* Update CHANGELOG.md

* Update lua bindings

---------

Co-authored-by: Dani Alias <[email protected]>
Co-authored-by: aismann <[email protected]>
Co-authored-by: smilediver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.5
Development

No branches or pull requests
2 participants
@halx99 @BIGCATDOG