fix: webVitals duplicate info #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielelpidio
changed the title
useReportWebVitals
dasfmi
reviewed
Dec 16, 2024
dasfmi
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilizes path in
useReportWebVitalsto only send metrics on hard navigation.Current implementation of
useReportWebVitalsget's triggered every time path changes without updating the vitals, this meant that vitals send were being duplicated on each soft navigation even though they are only measured on hard navigations, hence, we were seeing behaviors like the one reported on #234There seems to be talks around having soft navigations registered for web vitals but there's no current implementation for it in
next/web-vitals.