Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep when no input is available while streaming #98

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

lukasmalkmus
Copy link
Collaborator

Sleep on some loops when no inputs is available.

Closes #90.

@lukasmalkmus lukasmalkmus added the enhancement New feature or request label Nov 8, 2021
@lukasmalkmus lukasmalkmus added this to the v0.5.0 milestone Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@53dd7df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage        ?   14.22%           
=======================================
  Files           ?        9           
  Lines           ?      506           
  Branches        ?        0           
=======================================
  Hits            ?       72           
  Misses          ?      418           
  Partials        ?       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53dd7df...aa0fb44. Read the comment docs.

@lukasmalkmus lukasmalkmus force-pushed the fix-running-hot branch 2 times, most recently from 04a3d5d to aa0fb44 Compare November 9, 2021 14:31
@lukasmalkmus lukasmalkmus modified the milestones: v0.5.0, v0.6.0 Feb 16, 2022
@ImLunaHey
Copy link
Contributor

@lukasmalkmus is this PR still valid?

@lukasmalkmus
Copy link
Collaborator Author

Technically, yes. Apparently this got lost as no one else ever reported any issues. My idea was to test this branch against main. I couldn't imagine Go really uses up a lot of CPU when waiting on a select statement. By "test" I mean to run two long running jobs and monitor CPU usage.

@lukasmalkmus lukasmalkmus marked this pull request as ready for review August 19, 2024 10:19
@lukasmalkmus lukasmalkmus merged commit c4e9464 into main Aug 19, 2024
9 checks passed
@lukasmalkmus lukasmalkmus deleted the fix-running-hot branch August 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axiom CLI never sleeps
3 participants