fix(client): use axiom-go http transport options #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasfmi
approved these changes
Jan 29, 2024
lukasmalkmus
force-pushed
the
lukasmalkmus/fix-short-dial-timeout
branch
from
7365452
to
38d3860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw issues where the - indeeed very small - dial timeout could kick in when Go's resolver took to long to lookup a hostname, which resulted in
i/o timeouterrors.This PR uses the transport options from
axiom-gobut respecting some options we exlusively added in Axiom CLI, e.g.Proxy.