Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for bunyan logger with axiom #71

Closed
wants to merge 12 commits into from

Conversation

Bensigo
Copy link

@Bensigo Bensigo commented Aug 31, 2023

Bunyan Support

Added support for using Bunyan logger with axiom stream, to be able to push your logs to axiom

What is included

  • Test
  • example
  • Axiom stream for Bunyan
  • Docs

Copy link
Collaborator

@dasfmi dasfmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work there man. There is few formatting issues, but you need to add the package name to pnpm-workspace file and also the workspaces object in the root package.json so that the build,lint and test commands would run for this package as well.

packages/bunyan/src/index.ts Outdated Show resolved Hide resolved
packages/bunyan/src/index.ts Outdated Show resolved Hide resolved
packages/bunyan/src/index.ts Outdated Show resolved Hide resolved
@Bensigo Bensigo requested a review from dasfmi August 31, 2023 11:49
@Bensigo
Copy link
Author

Bensigo commented Sep 6, 2023

good work there man. There is few formatting issues, but you need to add the package name to pnpm-workspace file and also the workspaces object in the root package.json so that the build,lint and test commands would run for this package as well.

We talked about this, that we use workspace/* to automatically detect each package.

Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! some smog things

README.md Show resolved Hide resolved
examples/bunyan/package.json Outdated Show resolved Hide resolved
examples/bunyan/src/bunyan.ts Outdated Show resolved Hide resolved
examples/bunyan/src/bunyan.ts Outdated Show resolved Hide resolved
packages/bunyan/CHANGELOG.md Outdated Show resolved Hide resolved
packages/bunyan/jest.config.ts Outdated Show resolved Hide resolved
packages/bunyan/src/index.ts Outdated Show resolved Hide resolved
packages/bunyan/src/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@dasfmi dasfmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the conflict, then we can merge it 👍

@dasfmi dasfmi enabled auto-merge October 9, 2023 15:49
auto-merge was automatically disabled October 10, 2023 09:45

Head branch was pushed to by a user without write access

@Bensigo Bensigo requested a review from dasfmi October 10, 2023 09:48
@dasfmi dasfmi enabled auto-merge October 24, 2023 10:42
auto-merge was automatically disabled October 24, 2023 15:21

Head branch was pushed to by a user without write access

@dasfmi
Copy link
Collaborator

dasfmi commented Oct 30, 2024

closing this as there has been no activity for a lone time, feel free to open a new one.

@dasfmi dasfmi closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants