Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake process.env for browsers #26

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fake process.env for browsers #26

merged 1 commit into from
Jun 26, 2023

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Jun 26, 2023

Otherwise we get this:

Uncaught ReferenceError: process is not defined

Closes #24

@bahlo bahlo mentioned this pull request Jun 26, 2023
Closed
@bahlo bahlo force-pushed the fake-process-env branch from 63a58b5 to 2a53532 Compare June 26, 2023 11:04
@bahlo
Fake process.env for browsers
6fd08a4 
Otherwise we get this:
> Uncaught ReferenceError: process is not defined
@bahlo bahlo force-pushed the fake-process-env branch from 2a53532 to 6fd08a4 Compare June 26, 2023 11:06
@bahlo bahlo requested a review from bdsqqq June 26, 2023 11:10
bdsqqq
bdsqqq approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@bdsqqq bdsqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@bahlo bahlo merged commit 6c0b4a5 into main Jun 26, 2023
@bahlo bahlo deleted the fake-process-env branch June 26, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdsqqq bdsqqq bdsqqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes in browser on process in packages/js/src/httpClient.ts if not setting url
2 participants
@bahlo @bdsqqq