Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn when using personal tokens in axiom-js #215

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: warn when using personal tokens in axiom-js #215

merged 2 commits into from
Aug 14, 2024

Conversation

c-ehrlich
Copy link
Contributor

@c-ehrlich c-ehrlich commented Aug 12, 2024 •
edited
Loading

  • autofix some prettier issues (we should probably follow up by running it on the whole project and including a check in ci)
  • warn in console when creating Axiom or AxiomWithoutBatching with a personal token (xapt-*)
    • ...and tests to ensure this works
  • in a future release we will completely disallow using personal tokens

@c-ehrlich c-ehrlich merged commit ec22e79 into main Aug 14, 2024
11 checks passed
@c-ehrlich c-ehrlich deleted the cje/axm-3197-prevent-using-personal-tokens-in-axiom-js branch August 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasfmi dasfmi dasfmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-ehrlich @dasfmi