Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tabular option for query() #108

Merged
merged 19 commits into from
Sep 23, 2024
Merged

feat: add tabular option for query() #108

merged 19 commits into from
Sep 23, 2024

Conversation

dasfmi
Copy link
Collaborator

@dasfmi dasfmi commented Nov 10, 2023

No description provided.

@dasfmi dasfmi force-pushed the islam/axm-22-tabular-result-format-support-for-axiom-node branch from 3e113a3 to 25f6326 Compare November 16, 2023 14:24
@dasfmi dasfmi marked this pull request as ready for review January 10, 2024 11:44
@dasfmi dasfmi changed the title feat: use tablar format for query() feat: use tabular format for query() Feb 27, 2024
@gabrielelpidio gabrielelpidio force-pushed the islam/axm-22-tabular-result-format-support-for-axiom-node branch from f51281f to 90f9b1c Compare September 19, 2024 00:37
@gabrielelpidio gabrielelpidio changed the title feat: use tabular format for query() feat: add tabular option for query() Sep 19, 2024
ImLunaHey
ImLunaHey reviewed Sep 19, 2024
View reviewed changes
e2e/nextjs-app/test/ingest.spec.ts Outdated Show resolved Hide resolved
integration/src/client.spec.ts Show resolved Hide resolved
bahlo
bahlo approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but would be nice to have some way of easily getting to the events. the other sdks expose an iterator for each table, could do something similar.

packages/js/src/client.ts Outdated Show resolved Hide resolved
@bahlo bahlo merged commit b16925f into main Sep 23, 2024
11 checks passed
@bahlo bahlo deleted the islam/axm-22-tabular-result-format-support-for-axiom-node branch September 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielelpidio gabrielelpidio gabrielelpidio left review comments

@bahlo bahlo bahlo approved these changes

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

@ImLunaHey ImLunaHey Awaiting requested review from ImLunaHey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasfmi @bahlo @gabrielelpidio @ImLunaHey