update the getDefaultLogger to respect AXIOM_LOG_LEVEL

axiomhq · Feb 26, 2024 · 387f9ed · 387f9ed
1 parent cdf7315
commit 387f9ed
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 47 deletions.
diff --git a/packages/logger/src/index.ts b/packages/logger/src/index.ts
@@ -1,4 +1,4 @@
-import { LogLevel } from './levels';
+import { LOG_LEVEL, LogLevel } from './levels';
 import { Logger } from './logger';
 import { ConsoleTransport } from './transports/console';
 
@@ -7,8 +7,10 @@ export { LogEvent } from './event'
 export { LogLevel } from './levels'
 
 export function getDefaultLogger(): Logger {
+    const level = LogLevel[LOG_LEVEL as keyof typeof LogLevel];
+
     return new Logger({
-        logLevel: LogLevel.debug,
+        logLevel: level,
         autoFlush: true,
         transformers: [],
         transport: new ConsoleTransport(),

diff --git a/packages/logger/src/levels.ts b/packages/logger/src/levels.ts
@@ -1,4 +1,4 @@
-export const LOG_LEVEL = process.env.NEXT_PUBLIC_AXIOM_LOG_LEVEL || 'debug';
+export const LOG_LEVEL = process.env.NEXT_PUBLIC_AXIOM_LOG_LEVEL || process.env.AXIOM_LOG_LEVEL || 'debug';
 
 export enum LogLevel {
   debug = 0,

diff --git a/packages/logger/test/unit/logLevels.spec.ts b/packages/logger/test/unit/logLevels.spec.ts
@@ -1,6 +1,6 @@
-import { test, expect, vi } from 'vitest';
-import { getDefaultLogger, Logger, LogLevel } from '../src/index.ts';
-import { ConsoleTransport } from '../src/transports/console.ts';
+import { describe, it, expect, vi } from 'vitest';
+import { getDefaultLogger, Logger, LogLevel } from '../../src/index';
+import { ConsoleTransport } from '../../src/transports/console';
 
 vi.hoisted(() => {
   // stub axiom env vars before importing logger
@@ -10,48 +10,56 @@ vi.hoisted(() => {
 
 vi.useFakeTimers();
 
-test('log levels', async () => {
-  const mockedConsole = vi.spyOn(console, 'log');
 
-  const log = getDefaultLogger();
+describe('Testing log levels', () => {
+  it('detects environment variable log level', async () => {
+    const mockedConsole = vi.spyOn(console, 'log');
+    const log = getDefaultLogger();
 
-  log.info('test');
-  await log.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(0);
+    log.config.logLevel = LogLevel.error;
 
-  // test overriding log level per logger
-  let logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.error, transport: new ConsoleTransport(), transformers: [] });
-  logger.debug('hello');
-  logger.info('hello');
-  logger.warn('hello');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(0);
+    log.info('test');
+    await log.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(0);
+  })
 
-  logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.warn, transport: new ConsoleTransport(), transformers: [] });
-  logger.info('hello');
-  logger.debug('hello');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(0);
-
-  logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.info, transport: new ConsoleTransport(), transformers: [] });
-  logger.debug('hello');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(0);
-
-  // disabled logging
-  logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.off, transport: new ConsoleTransport(), transformers: [] });
-  logger.error('no logs');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(0);
-
-  logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.error, transport: new ConsoleTransport(), transformers: [] });
-  logger.warn('warn');
-  logger.error('error');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(1);
-
-  logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.debug, transport: new ConsoleTransport(), transformers: [] });
-  logger.warn('hello');
-  await logger.flush();
-  expect(mockedConsole).toHaveBeenCalledTimes(2);
-});
+  it('log levels', async () => {
+    const mockedConsole = vi.spyOn(console, 'log');
+
+    // test overriding log level per logger
+    let logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.error, transport: new ConsoleTransport(), transformers: [] });
+    logger.debug('hello');
+    logger.info('hello');
+    logger.warn('hello');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(0);
+
+    logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.warn, transport: new ConsoleTransport(), transformers: [] });
+    logger.info('hello');
+    logger.debug('hello');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(0);
+
+    logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.info, transport: new ConsoleTransport(), transformers: [] });
+    logger.debug('hello');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(0);
+
+    // disabled logging
+    logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.off, transport: new ConsoleTransport(), transformers: [] });
+    logger.error('no logs');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(0);
+
+    logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.error, transport: new ConsoleTransport(), transformers: [] });
+    logger.warn('warn');
+    logger.error('error');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(1);
+
+    logger = new Logger({ args: {}, autoFlush: false, logLevel: LogLevel.debug, transport: new ConsoleTransport(), transformers: [] });
+    logger.warn('hello');
+    await logger.flush();
+    expect(mockedConsole).toHaveBeenCalledTimes(2);
+  });
+})