[fix] transactions trie witness generation after 4844 and OP stack support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: transaction trie needs tx rlp to support 4844 No ZK circuit code was changed. To generate witness transaction MPT proofs, we reconstruct the transactions trie of a block from the raw transactions returns by a JSON-RPC call for a block. To construct the trie, we must compute the RLP encoding of each raw transaction. Previously, we used `ethers_core` to do this. However `ethers_core` has not been updated after EIP 4844 (Dencun) for the new Type 3 Blob Transaction. At first I tried to use `reth`'s transaction RLP encoding logic. However `reth` uses an internal type to represent transactions. Since we get transactions from RPC calls, we need an adapter from the RPC type. This latter type is provided in `alloy_rpc_types`, but in writing the converter from RPC type to reth primitive type, I ran into issues that many structs were defined in parallel in the two crates, and also there was inconsistency in the use of `ruint` primitives. I decided it was easier just to keep `ethers_core` types for now and add custom implementations of RLP for the new transaction type. Also added RLP support for OP stack deposit transactions. Moved some of the trie code from `axiom-query` to `axiom-eth` to remove redundancy. References: - https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4844.md - https://github.com/paradigmxyz/reth/blob/28f3a2e2d9525bf2f6373e755e2d6dc0c2f97821/crates/primitives/src/transaction/mod.rs#L128 - https://github.com/alloy-rs/alloy/blob/d5967abdbae58dd84acc4c1ee31345108d42d041/crates/rpc-types/src/eth/transaction/mod.rs * feat: switch to `ethers` v2.0.14 so `OtherField` and "optimism" are compatible * chore: storageProof key is now U256 instead of H256 * chore: add rpc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ZK circuit code was changed.
To generate witness transaction MPT proofs, we reconstruct the transactions trie of a block from the raw transactions returns by a JSON-RPC call for a block. To construct the trie, we must compute the RLP encoding of each raw transaction. Previously, we used
ethers_coreto do this. Howeverethers_corehas not been updated after EIP 4844 (Dencun) for the new Type 3 Blob Transaction.The longer term plan is to switch to using
alloy_rpc_types. However there is currently no RLP implementation for transaction and receipts in alloy (they are inreth-primitives, but the types are incompatible). Therefore short term it is simpler to continue usingethers_corebut patch the implementations as we do here.axiom-querytoaxiom-ethto remove redundancy.References: