trie: add trie db wrapper; refactor trienode #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
force-pushed
the
rework-trie-nodeset
branch
2 times, most recently
from
a43b785
to
084eac9
Compare
Francesco4203
changed the title
Francesco4203
force-pushed
the
rework-trie-nodeset
branch
from
084eac9
to
16d80b1
Compare
Francesco4203
force-pushed
the
rework-trie-nodeset
branch
from
16d80b1
to
bc1961d
Compare
|
noted, it will split trie/database.go -> into trie/triedb/<hashdb/pathdb> structure. |
huyngopt1994
reviewed
Oct 1, 2024
| // Node is a wrapper which contains the encoded blob of the trie node and its | ||
| // unique hash identifier. It is general enough that can be used to represent | ||
| // trie nodes corresponding to different trie implementations. | ||
| type Node struct { |
There was a problem hiding this comment.
Rename from memoryNode-> Node
huyngopt1994
reviewed
Oct 1, 2024
huyngopt1994
reviewed
Oct 1, 2024
huyngopt1994
reviewed
Oct 1, 2024
| } | ||
|
|
||
| // AddLeaf adds the provided leaf node into set. | ||
| func (set *NodeSet) AddLeaf(parent common.Hash, blob []byte) { |
There was a problem hiding this comment.
before, they init leaf obj and pass directly here.
func (set *NodeSet) addLeaf(leaf *leaf) {
set.leaves = append(set.leaves, leaf)
}
huyngopt1994
reviewed
Oct 1, 2024
| } | ||
| //} else { |
There was a problem hiding this comment.
hm Why we comment here. ?
There was a problem hiding this comment.
It will be later enabled for path based scheme
trie: change name WithPrev => NodeWithPrev rawdb: add schema_test
huyngopt1994
merged commit 4a72920
into
axieinfinity:path-base-implementing
1 check passed
Francesco4203
added a commit
that referenced
this pull request
Oct 17, 2024
* trie: add wrapper for database * trie: refactor trie node * all: fix test * rawdb, trie: fix comment trie: change name WithPrev => NodeWithPrev rawdb: add schema_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Changes: