Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/protocols/snap: fix batch writer when resuming an aborted sync (#… #587

Conversation

huyngopt1994
Copy link
Collaborator

https://go.dev/blog/loopvar-preview, in path-base-implementing, we will use the callback function when generating a trie for per task which triggers this issue

	task.genTrie = trie.NewStackTrie(func(owner common.Hash, path []byte, hash common.Hash, val []byte) {
					rawdb.WriteTrieNode(task.genBatch, owner, path, hash, val, s.scheme)
				})

@huyngopt1994 huyngopt1994 merged commit 3939ade into path-base-implementing Sep 27, 2024
1 check passed
@huyngopt1994 huyngopt1994 deleted the snap-fix-issues-clouser-point-same-batch-in-go-1.20 branch September 27, 2024 05:57
Francesco4203 pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants