trie: refactor tracer #581
Conversation
| order = append(order, owner) | ||
| } | ||
| if _, ok := nodes.sets[common.Hash{}]; ok { | ||
| order = append(order, common.Hash{}) |
There was a problem hiding this comment.
Here, the trie with owner empty representing the account trie is pushed to the back of the array so that all the storage dirty nodes are flushed first.
Reference: ethereum/go-ethereum@5758d1f
There was a problem hiding this comment.
Add this like comment in the source code too ?
There was a problem hiding this comment.
There is a comment like this above
// Note, the storage tries must be flushed before the account trie to
// retain the invariant that children go into the dirty cache first.
Do you think this is clear enough?
There was a problem hiding this comment.
the trie with owner empty representing the account trie is pushed to the back of the array so that all the storage dirty nodes are flushed first. I think u can add those blocks for showing why we use common.Hash{} here.
| @@ -628,16 +630,16 @@ func (t *Trie) Commit(collectLeaf bool) (common.Hash, *NodeSet, error) { | |||
| } | |||
|
|
|||
| // hashRoot calculates the root hash of the given trie | |||
| func (t *Trie) hashRoot() (node, node, error) { | |||
| func (t *Trie) hashRoot() (node, node) { | |||
There was a problem hiding this comment.
No error will ever be returned, so just not return error here.
Francesco4203
force-pushed
the
rework-tracer
branch
3 times, most recently
from
b58387d
to
defda57
Compare
|
One thing note here in PR is tracer is enabled by default |
|
I think u should spit one commit in the PR into more commits for easily reviewing, merging into one 's hard for understanding the purpose of changes. |
| // but not present in database previously), for example the node was | ||
| // embedded in the parent and now deleted from the trie. In this case | ||
| // it's noop from database's perspective. | ||
| val := c.tracer.getPrev(path) |
There was a problem hiding this comment.
hm that's interested, so they don't need to track the deleted nodes any more from trie in tracer, and mark it deleted 🤔
Francesco4203
force-pushed
the
rework-tracer
branch
from
8fc5346
to
babdb0b
Compare
huyngopt1994
merged commit 45ee924
into
axieinfinity:path-base-implementing
* trie: refactor tracer * fix: add description
Reference: ethereum/go-ethereum#26763
Also applied some related changes from this PR: ethereum/go-ethereum#27160
Changes:
trie/utils.gototrie/tracer.gooriginfield intracertoaccessList, still the same functionmarkUpdatedandmarkDeletedintoaddNodecommitter: move logic to mark deleted nodes tocommitter.storefor consistency with the mark update logic