Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profile] Allow candidate to register profile #282

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[Profile] Allow candidate to register profile #282

merged 1 commit into from
Sep 22, 2023

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Sep 21, 2023

Description

  • Candidate admin can register their profile.

Contract changes

The table below shows the following info:

  • Logic: the logic is changed.
  • ABI: the ABI is changed.
  • Init data: new storage field is declared and needs initializing.
  • Dependent: needs to be changed due to changes in other contracts.
Contract name Logic ABI Init data Dependent
Profile x x x

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@huyhuynh3103 huyhuynh3103 merged commit b15bd24 into release/v0.6.3 Sep 22, 2023
@nxqbao nxqbao deleted the feat/allow-candidate-add-profile branch September 25, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minh-bq minh-bq minh-bq approved these changes

@huyhuynh3103 huyhuynh3103 huyhuynh3103 approved these changes

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

@phuctd95 phuctd95 Awaiting requested review from phuctd95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nxqbao @ducthotran2010 @huyhuynh3103 @minh-bq