Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Fix assertion of maintenance elapsed #217

Merged
merged 2 commits into from
May 11, 2023
Merged

[Maintenance] Fix assertion of maintenance elapsed #217

merged 2 commits into from
May 11, 2023

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Apr 21, 2023

Description

Wrong assertion caused validators cannot set maintenance at minBlockDuration but minBlockDuration + 1 epoch.

Contract changes

The table below shows the following info:

  • Logic: the logic is changed.
  • ABI: the ABI is changed.
  • Init data: new storage field is declared and needs initializing.
  • Dependent: needs to be changed due to changes in other contracts.
Contract name Logic ABI Init data Dependent
BridgeTracking
GovernanceAdmin
Maintenance [x]
SlashIndicator
Staking
StakingVesting
ValidatorSet

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao merged commit fed915c into dev May 11, 2023
@nxqbao nxqbao deleted the fix/assert-on-maintenance-elapsed branch May 11, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @ducthotran2010