Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-generate src/tables.rs: Rm all build-deps & build.rs #8

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Pre-generate src/tables.rs: Rm all build-deps & build.rs #8

merged 1 commit into from
Jul 16, 2023

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented May 3, 2023 •
edited
Loading

Fixed #7

Signed-off-by: Jiahao XU [email protected]

@NobodyXu
Copy link
Contributor Author

NobodyXu commented May 3, 2023

@axelf4 I've verified that adding src/tables.rs to Cargo.toml:include does work but requires you to use --allow-dirty when cargo-publish.

I've verified that cargo publish --allow-dirty does include src/tables.rs and generates a crate tarball that pass all tests.

I've also included a CONTRIBUTING.md on how to build and publish this crate.

@NobodyXu
Copy link
Contributor Author

NobodyXu commented May 3, 2023

I also added caching for generated src/tables.rs so that the ci runs under 1m.

@NobodyXu
Copy link
Contributor Author

@axelf4 Hello, can you review this please?
Thank you!

@bjorn3 bjorn3 mentioned this pull request Jun 8, 2023
Merged
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jun 9, 2023

@axelf4 Pinging since this issue has been stale for one month

@axelf4
Copy link
Owner

axelf4 commented Jun 14, 2023

Sorry, I have been too busy with my thesis to give this the attention it deserves. I promise to get to this within a week.

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jul 8, 2023

@axelf4 Friendly ping as it has been stale for another 3 weeks

@NobodyXu NobodyXu mentioned this pull request Jul 9, 2023
Merged
@NobodyXu @axelf4
Pre-generate src/tables.rs
01f1dcd 
This avoids the need for users to run the build script when installing
the crate from crates.io.
@axelf4 axelf4 merged commit f209371 into axelf4:master Jul 16, 2023
@axelf4
Copy link
Owner

axelf4 commented Jul 16, 2023

Thanks and sorry for the delay! I made some stylistic changes and squashed the commits before merging.

@NobodyXu NobodyXu deleted the pre-generate-tables-rs branch July 17, 2023 01:44
@NobodyXu
Copy link
Contributor Author

@axelf4 Thanks! Can we have a new release please?

@NobodyXu
Copy link
Contributor Author

@axelf4 Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-generate tables.rs instead of doing it in build.rs?
2 participants
@NobodyXu @axelf4