Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus)!: lock/unlock tokens from/to amplifier in core #2188

Conversation

fish-sammy
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner September 28, 2024 21:58
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 39.20%. Comparing base (2ee5604) to head (f97be3d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/nexus/types/mock/expected_keepers.go 55.55% 11 Missing and 1 partial ⚠️
x/nexus/keeper/wasm_message_route.go 58.33% 2 Missing and 3 partials ⚠️
x/nexus/exported/types.go 0.00% 3 Missing ⚠️
x/nexus/keeper/msg_dispatcher.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
+ Coverage   39.17%   39.20%   +0.02%     
==========================================
  Files         373      373              
  Lines       31676    31726      +50     
==========================================
+ Hits        12408    12437      +29     
- Misses      18331    18348      +17     
- Partials      937      941       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from AXE-5101-Refactor-to-move-coin-locking-unlocking-logic-from-axelarnet-to-nexus to main October 4, 2024 19:43
@haiyizxx haiyizxx merged commit bc0ae8f into main Oct 7, 2024
8 of 9 checks passed
@haiyizxx haiyizxx deleted the AXE-4191-Support-locking-unlocking-of-gateway-tokens-on-ITS-hub-in-core branch October 7, 2024 15:36
haiyizxx added a commit that referenced this pull request Oct 15, 2024
fish-sammy added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants